From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762129AbYETS0A (ORCPT ); Tue, 20 May 2008 14:26:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756549AbYETSZw (ORCPT ); Tue, 20 May 2008 14:25:52 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:34318 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755615AbYETSZv (ORCPT ); Tue, 20 May 2008 14:25:51 -0400 Date: Tue, 20 May 2008 13:27:57 -0500 From: Michael Halcrow To: Cyrill Gorcunov Cc: LKML Subject: Re: [Q] eCryptFS race window? Message-ID: <20080520182757.GB32643@halcrowt61p.austin.ibm.com> Reply-To: Michael Halcrow References: <20080520170321.GC6926@cvg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080520170321.GC6926@cvg> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2008 at 09:03:21PM +0400, Cyrill Gorcunov wrote: > it seems there is a few potential race window in eCryptFS which I > was trying to fix but it requires more deeper eCrypFS knowledge that > have (at least only by understanding eCryptFS in big picture it is > possible to fix this problem by elegant path). So what is the > problem - the procedures > > ecryptfs_miscdev_poll > ecryptfs_miscdev_read > > does take ecryptfs_daemon_hash_mux mutex and then daemon->mux _but_ > releases them not in exactly backward order as it should. My patches > (not in mainline but you saw them) was screwed up 'cause > mutex_is_locked could release mutex acquired by another process and > that is wrong. But I've a hope that I'm simply *wrong* about this > possible races ;) Take a look please. I cannot find an execution path whereby one of the two must re-acquire ecryptfs_daemon_hash_mux in order to release daemon->mux, so I do not think we will ever have deadlock between those two functions. Mike