From: "Frank Ch. Eigler" <fche@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Adrian Bunk <bunk@kernel.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@sunset.davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
systemtap@sources.redhat.com
Subject: Re: [2.6 patch] unexport uts_sem
Date: Tue, 20 May 2008 14:38:02 -0400 [thread overview]
Message-ID: <20080520183802.GA686@redhat.com> (raw)
In-Reply-To: <20080520172730.GA2361@infradead.org>
Hi -
On Tue, May 20, 2008 at 01:27:30PM -0400, Christoph Hellwig wrote:
> > Am I correct that this would makes it invalid for modules to call
> > utsname() (since the protective semaphore is now hidden)?
>
> Yesm they should never had done that anyway. The module support
> does it's own version checking already.
Sorry, I misspoke - this check is intended not to cross-check
kernel-devel and the kernel itself, but the debuginfo or similar data
that is given to describe target of a systemtap script. I guess for
new enough kernels we'll just do that using buildid hash codes.
By the way, there do appear to be a few suspect in-tree users of
utsname() without uts_sem locking (usb/storage/usb.c, cifs/connect.c,
char/random.cc, fs/lockd/clntproc.c, ...). If these need to be fixed,
then wouldn't uts_sem need to come back exported?
- FChE
next prev parent reply other threads:[~2008-05-20 18:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:29 Adrian Bunk
2008-05-20 17:16 ` Frank Ch. Eigler
2008-05-20 17:27 ` Christoph Hellwig
2008-05-20 18:38 ` Frank Ch. Eigler [this message]
2008-05-21 12:37 ` Christoph Hellwig
2008-05-21 14:48 ` Steve French (smfltc)
2008-05-21 17:51 ` [PATCH] usb-storage: don't call utsname() Alan Stern
2008-05-21 18:09 ` Greg KH
2008-05-21 18:19 ` Steve French (smfltc)
2008-05-21 18:52 ` Christoph Hellwig
2008-05-21 19:35 ` Greg KH
2008-05-21 21:01 ` Steve French (smfltc)
-- strict thread matches above, loose matches on Subject: below --
2008-04-23 9:52 [2.6 patch] unexport uts_sem Adrian Bunk
2008-04-23 10:50 ` David Miller
2005-04-15 15:10 Adrian Bunk
2005-03-04 0:50 Adrian Bunk
2005-03-04 12:57 ` Alan Cox
2005-03-04 13:28 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520183802.GA686@redhat.com \
--to=fche@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=davem@sunset.davemloft.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®