From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764730AbYEVBbV (ORCPT ); Wed, 21 May 2008 21:31:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759281AbYEVBas (ORCPT ); Wed, 21 May 2008 21:30:48 -0400 Received: from outbound-mail-40.bluehost.com ([69.89.20.194]:32879 "HELO outbound-mail-40.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S935911AbYEVBar convert rfc822-to-8bit (ORCPT ); Wed, 21 May 2008 21:30:47 -0400 From: Jesse Barnes To: Shaohua Li Subject: Re: [BISECTED] pata_jmicron: no drives found on post 2.6.25 kernels Date: Wed, 21 May 2008 18:30:42 -0700 User-Agent: KMail/1.9.9 Cc: Luca Tettamanti , Plamen Petrov , linux-kernel@vger.kernel.org References: <68676e00805211245u1a1973e5g847bd7e8a6c9e5a7@mail.gmail.com> <1211418924.15223.1.camel@sli10-desk.sh.intel.com> In-Reply-To: <1211418924.15223.1.camel@sli10-desk.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200805211830.42485.jbarnes@virtuousgeek.org> X-Identified-User: {642:box128.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.27.49 authed with jbarnes@virtuousgeek.org} DomainKey-Status: no signature Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, May 21, 2008 6:15 pm Shaohua Li wrote: > On Wed, 2008-05-21 at 21:45 +0200, Luca Tettamanti wrote: > > On Wed, May 21, 2008 at 10:58 AM, Shaohua Li wrote: > > > On Tue, 2008-05-20 at 19:09 +0300, Plamen Petrov wrote: > > >> Shaohua Li написа: > > >> > On Tue, 2008-05-20 at 01:37 +0300, Plamen Petrov wrote: > > >> >> Hello, folks! > > >> >> > > >> >> After 2.6.26 merge window opened, the optical drives in my > > >> >> computer, hanging off a JMicron controler were not detected > > >> >> by linux any more. > > >> >> > > >> >> Luca Tettamanti reported similar troubles: > > >> >> http://marc.info/?l=linux-kernel&m=120958791323911&w=2 > > >> >> > > >> >> Its been 20 days, so I decided to bisect. > > >> >> git bisect revealed that commit > > >> >> 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b > > >> >> is the one causing pata_jmicron to fail to detect drives, > > >> >> connected to the JMicron controler on my motherboard. > > >> >> At least in my case, anyway... > > >> >> Changing kernel config to CONFIG_PCIEASPM=n makes the drives > > >> >> attached to the JMicron SATA/PATA controller usable again. > > >> > > > >> > When you enable this option, did you change any ASPM policy? By > > >> > default, we are using the BIOS setting, so it shouldn't change any > > >> > thing. > > >> > > >> No, I did not change any ASPM policy, mainly because I do not how. > > >> > > >> > Also can you please send me the 'lspci -vvvxxxx' output with/without > > >> > the ASPM enabled? > > > > > > Can you please try below patch? > > > > I confirm that the patch fixes the issue when CONFIG_ASPM is enabled. > > > > > The Slot 03:00.* of JMicron controller has two functions, but one is > > > PCIE endpoint the other isn't PCIE device, very strange. > > > > Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm > > attaching the output of lspci. > > Jesse, can you take this patch. It should be safe for 2.6.26. Definitely. Thanks Shaohua. Jesse