From: Francois Romieu <romieu@fr.zoreil.com>
To: Emmanuel Colbus <emmanuel.colbus@ovh.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment
Date: Wed, 21 May 2008 20:53:06 +0200 [thread overview]
Message-ID: <20080521185306.GA9320@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <48342CDF.1040304@ovh.net>
Emmanuel Colbus <emmanuel.colbus@ovh.net> :
> Calling "PCI base addr 1" something that can actually lie at
> PCI_BASE_ADDR_2 is misleading. Patch follows.
>
> signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
I do not approve:
- the patch does not follow the comment style of the driver
- the comment should be removed, not silly augmented
--
Ueimor
next prev parent reply other threads:[~2008-05-21 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 14:08 Emmanuel Colbus
2008-05-21 18:53 ` Francois Romieu [this message]
2008-05-22 8:08 ` Emmanuel Colbus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521185306.GA9320@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=emmanuel.colbus@ovh.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®