From: Andrew Morton <akpm@linux-foundation.org>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
Paul Menage <menage@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH -mm] remove node_ prefix_from ns subsystem
Date: Wed, 21 May 2008 22:06:57 -0700 [thread overview]
Message-ID: <20080521220657.12e8e8c9.akpm@linux-foundation.org> (raw)
In-Reply-To: <48344409.9090903@fr.ibm.com>
On Wed, 21 May 2008 17:47:21 +0200 Cedric Le Goater <clg@fr.ibm.com> wrote:
> From: Cedric Le Goater <clg@fr.ibm.com>
>
> This is a slight change in the namespace cgroup subsystem api.
>
What are the reasons for making this change?
> ---
> kernel/cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: 2.6.26-rc2-mm1/kernel/cgroup.c
> ===================================================================
> --- 2.6.26-rc2-mm1.orig/kernel/cgroup.c
> +++ 2.6.26-rc2-mm1/kernel/cgroup.c
> @@ -2903,7 +2903,7 @@ int cgroup_clone(struct task_struct *tsk
> cg = tsk->cgroups;
> parent = task_cgroup(tsk, subsys->subsys_id);
>
> - snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "node_%d", tsk->pid);
> + snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "%d", tsk->pid);
>
> /* Pin the hierarchy */
> atomic_inc(&parent->root->sb->s_active);
This is user-visible, isn't it? Been there since October. How can we
safely change it now?
next prev parent reply other threads:[~2008-05-22 5:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 15:47 Cedric Le Goater
2008-05-21 20:03 ` Serge E. Hallyn
2008-05-22 5:06 ` Andrew Morton [this message]
2008-05-22 7:11 ` Paul Menage
2008-05-22 7:32 ` Andrew Morton
2008-05-22 7:36 ` Cedric Le Goater
2008-05-22 8:10 ` Andrew Morton
2008-05-22 8:23 ` Paul Menage
2008-05-22 8:36 ` Andrew Morton
2008-05-22 9:21 ` Cedric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521220657.12e8e8c9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®