From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057AbYEVHMV (ORCPT ); Thu, 22 May 2008 03:12:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765559AbYEVHLz (ORCPT ); Thu, 22 May 2008 03:11:55 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:57639 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765044AbYEVHLy (ORCPT ); Thu, 22 May 2008 03:11:54 -0400 Date: Thu, 22 May 2008 09:12:30 +0200 From: Sam Ravnborg To: Jaroslav Kysela Cc: Rene Herman , Jeff Garzik , Takashi Iwai , LKML , Linus Torvalds , ALSA development Subject: Re: Moving sound/* to drivers/ ? Message-ID: <20080522071230.GB18607@uranus.ravnborg.org> References: <4834B252.1080700@garzik.org> <4834B5E2.3040301@keyaccess.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 22, 2008 at 08:26:39AM +0200, Jaroslav Kysela wrote: > On Thu, 22 May 2008, Rene Herman wrote: > > > On 22-05-08 01:37, Jeff Garzik wrote: > > > > > Speaking as a former OSS driver maintainer, I always preferred > > > drivers/sound. > > > > > > Though Rene's suggestion (use both sound/ and drivers/sound/) might make > > > sense if the subsystem code is huge -- I supported the drivers/block/ -> > > > block/ code movement for example. > > > > Well, not _huge_ but ALSA is very much structured like that; large middle > > layer with "miniport" drivers (I do by the way expect this was also Takashi > > plan originally due to him using sound/* and not just "sound/"; that is, I > > took the * to be shorthand for isa, pci, usb and so on) > > > > From a structural view, the PCM core is just as much not a driver as the IP > > protocol isn't one and moving all of sound/ to drivers/ would trade the > > current "why are the drivers not under drivers/?" issue for a "why is all this > > non-driver code under drivers/?". > > > > This "net model" of sound/ and drivers/sound/ would be cleanest I feel. > > Yes, it was one reason why I used 'sound/' as root of the ALSA tree. The > second reason was to move old OSS tree to new directory to make less > confusion. And the third reason was to just keep ALSA directory same as in > our local development tree (which is out-of-kernel tree - containing only > ALSA parts). That out-of-tree stuff could mirror the kernel directory layout - no? Then you could have both drivers/ and sound/ in that tree. We should try to opimize the kernel directory layout to fit the kernel best and then adapt the out-of-tree stuff to the kernel (IMHO). Sam