From: Paul Jackson <pj@sgi.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
menage@google.com
Subject: Re: [PATCH] cpusets: fix bug of adding inexistent cpu or mem
Date: Fri, 23 May 2008 09:20:25 -0500 [thread overview]
Message-ID: <20080523092025.0e3a7eff.pj@sgi.com> (raw)
In-Reply-To: <483676AD.9020303@cn.fujitsu.com>
Lai wrote:
> Adding inexistent cpu to a cpuset will be omitted quietly.
> It should return -EINVAL.
I like this PATCH - thank-you. It was definitely a bug that
trying to add a nonexistent CPU to a cpuset emptied that cpuset
of its current CPUs, returning "success", not an "error".
Acked-by: Paul Jackson <pj@sgi.com>
(By the way, the word "inexistent" is not so commonly used
as is the word "nonexistent", but both words are legitimate,
and mean the same thing.)
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
prev parent reply other threads:[~2008-05-23 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 7:47 Lai Jiangshan
2008-05-23 14:20 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523092025.0e3a7eff.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome