From: Stephen Rothwell <sfr@au1.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] viotape: Push down BKL ioctls
Date: Fri, 23 May 2008 13:04:42 +1000 [thread overview]
Message-ID: <20080523130442.54034a2f.sfr@au1.ibm.com> (raw)
In-Reply-To: <20080522222012.3a07bd57@core>
Hi Alan,
On Thu, 22 May 2008 22:20:12 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> -static int viotap_ioctl(struct inode *inode, struct file *file,
> - unsigned int cmd, unsigned long arg)
> +static long viotap_ioctl(struct file *file, unsigned int cmd,
> + unsigned long arg)
The inode parameter is used in this function (so it won't build after
this patch) but in a weird way. I will do an alternate patch.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2008-05-23 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 21:20 Alan Cox
2008-05-23 3:04 ` Stephen Rothwell [this message]
2008-05-23 5:12 ` [PATCH] [POWERPC] viotape: use unlocked_ioctl Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523130442.54034a2f.sfr@au1.ibm.com \
--to=sfr@au1.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®