From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: [RFC] Circular include dependencies
Date: Fri, 23 May 2008 14:20:34 +0100 [thread overview]
Message-ID: <20080523132034.GB15384@flint.arm.linux.org.uk> (raw)
Hi,
Having discovered some circular include dependencies in the ARM header
files which were causing build issues, I created a script to walk ARM
includes and report any similar issues found - which includes traversing
any referenced linux/ includes.
It identified the following two in include/linux/:
linux/mmzone.h <- linux/memory_hotplug.h <- linux/mmzone.h
linux/mmzone.h <- linux/topology.h <- linux/mmzone.h
Checking them by hand reveals that these are real. Whether they're
capable of causing a problem or not, I'm not going to comment on.
However, they're not a good idea and someone should probably look at
resolving the loops.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next reply other threads:[~2008-05-23 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 13:20 Russell King [this message]
2008-05-24 1:17 ` Andrew Morton
2008-05-26 13:10 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523132034.GB15384@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®