mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] snapshot: Push BKL down into ioctl handlers
Date: Fri, 23 May 2008 13:22:32 +0200	[thread overview]
Message-ID: <200805231322.33321.rjw@sisk.pl> (raw)
In-Reply-To: <20080523120452.6feefed0@core>

On Friday, 23 of May 2008, Alan Cox wrote:
> > >  
> > > +	lock_kernel();
> > > +
> > 
> > Hm, well, I admit I'm a bit ignorant as far as the chardev locking is
> > concerned, but can you please tell me why would that be wrong if we didn't call
> > lock_kernel() here at all?
> 
> I've just been pushing the lock down. If the code already has enough
> internal locking for things like multiple ioctls in parallel then you can
> probably kill it entirely - but that needs someone who knows that driver
> well to decide and evaluate.

Thanks, I'll have a look.

ACK for the patch from me.

Thanks,
Rafael

  reply	other threads:[~2008-05-23 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22 21:25 Alan Cox
2008-05-23  1:09 ` Rafael J. Wysocki
2008-05-23 11:04   ` Alan Cox
2008-05-23 11:22     ` Rafael J. Wysocki [this message]
2008-06-02 21:33       ` [RFC][PATCH] snapshot: Use pm_mutex for mutual exclusion Rafael J. Wysocki
2008-06-03 22:20         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805231322.33321.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®