From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>,
peter.oberparleiter@de.ibm.com, linux-kernel@vger.kernel.org,
ltp-coverage@lists.sourceforge.net, oberparleiter@googlemail.com
Subject: Re: [PATCH 6/7] kbuild: make source and include paths absolute
Date: Fri, 23 May 2008 21:09:50 +0200 [thread overview]
Message-ID: <20080523190950.GA32541@uranus.ravnborg.org> (raw)
In-Reply-To: <20080523111707.89df9f67.akpm@linux-foundation.org>
On Fri, May 23, 2008 at 11:17:07AM -0700, Andrew Morton wrote:
> On Fri, 23 May 2008 20:18:40 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > On Thu, May 22, 2008 at 08:17:24PM -0700, Andrew Morton wrote:
> > > On Mon, 19 May 2008 10:44:56 +0200 Peter Oberparleiter <peter.oberparleiter@de.ibm.com> wrote:
> > >
> > > > From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
> > > >
> > > > Change all source and include paths to absolute form when
> > > > CONFIG_GCOV_PROFILE is enabled.
> > > >
> > > > Example:
> > > >
> > > > gcc -Idir1 -c a.c -o a.o
> > > >
> > > > will become
> > > >
> > > > gcc -I/path/to/dir1 -c /path/to/a.c -o a.o
> > > >
> > > > Required by the gcov profiling infrastructure: when compiling with
> > > > option -fprofile-arcs, gcc stores file names inside object files.
> > > > Relative paths prevent the gcov tool from finding corresponding source
> > > > files.
> > >
> > > I don't like this. It converts the compiler error messages from
> > > relative paths to absolute paths which is rather obnoxious when
> > > all kernel developent is (or should be) base-directory-agnostic.
> >
> > The compiler error messages are already absolute paths when using O=
> > (see e.g. all error messages sent by me in recent years).
> >
>
> Well I guess that's understandable with O=.
>
> But I find it rather nasty. (I guess it'd be less nasty if I were to
> get off my butt and work out how to teach rxvt that "/" is a word
> separator).
>
> What do others think?
That the gcov tool has a bug if it insist on using absolute paths.
And thus we should fix gcov and not workaround it in the kernel.
Sam
next prev parent reply other threads:[~2008-05-23 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 8:44 Peter Oberparleiter
2008-05-19 13:45 ` Jan Blunck
2008-05-23 3:17 ` Andrew Morton
2008-05-23 17:18 ` Adrian Bunk
2008-05-23 18:17 ` Andrew Morton
2008-05-23 19:09 ` Sam Ravnborg [this message]
2008-05-23 19:42 ` Vegard Nossum
2008-05-23 19:52 ` Sam Ravnborg
2008-05-27 9:16 ` Peter Oberparleiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523190950.GA32541@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp-coverage@lists.sourceforge.net \
--cc=oberparleiter@googlemail.com \
--cc=peter.oberparleiter@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome