From: David Brownell <david-b@pacbell.net>
To: avorontsov@ru.mvista.com
Cc: Pierre Ossman <drzeus-mmc@drzeus.cx>,
David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
Gary Jennejohn <garyj@denx.de>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver
Date: Sat, 24 May 2008 12:56:32 -0700 [thread overview]
Message-ID: <200805241256.32639.david-b@pacbell.net> (raw)
In-Reply-To: <20080523182754.GA26891@polina.dev.rtsoft.ru>
On Friday 23 May 2008, Anton Vorontsov wrote:
>
> This is second attempt to write the OpenFirmware bindings for the
> MMC-over-SPI (and SPI bindings in general).
Summary: an OF-specific wrapper around the mmc_spi platform code.
I think a wrapper to encapsulate all the OF-specific knowledge makes
much sense here.
The only thing that looks odd to me about this is that the wrapper
is a spi_device rather than an of_device. To me it makes more sense
to just have an of_device setting up the right spi_device. (Though
maybe I missed some discussion about why that can't work.)
Example: drivers/usb/host/sl811_cs.c does that for PCMCIA card
that just wraps an sl811 chip that's more often used standalone.
The PCMCIA descriptors being analagous to OF device table entries.
- Dave
next prev parent reply other threads:[~2008-05-24 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 18:27 Anton Vorontsov
2008-05-23 18:28 ` [RFC PATCH 1/2] mmc_spi: export probe and remove functions Anton Vorontsov
2008-05-26 12:18 ` Pierre Ossman
2008-05-26 12:25 ` Anton Vorontsov
2008-05-26 13:10 ` Anton Vorontsov
2008-06-01 10:18 ` Pierre Ossman
2008-06-02 12:53 ` Anton Vorontsov
2008-06-05 21:16 ` Pierre Ossman
2008-05-23 18:28 ` [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver Anton Vorontsov
2008-05-24 2:35 ` Stephen Rothwell
2008-05-26 11:58 ` Anton Vorontsov
2008-05-24 5:19 ` Grant Likely
2008-05-24 14:32 ` Jochen Friedrich
2008-05-24 23:14 ` Segher Boessenkool
2008-05-24 23:06 ` Segher Boessenkool
2008-05-26 11:49 ` Anton Vorontsov
2008-05-26 22:19 ` David Brownell
2008-05-26 23:15 ` Anton Vorontsov
2008-05-24 19:56 ` David Brownell [this message]
2008-05-25 4:47 ` [RFC] OpenFirmware bindings for the MMC-over-SPI driver Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805241256.32639.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=drzeus-mmc@drzeus.cx \
--cc=g.liakhovetski@gmx.de \
--cc=garyj@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®