mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Komuro <komurojun-mbn@nifty.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: [PLEASE REVERT]  "Add a WARN_ON_ONCE" at  net/sched/sch_generic.c:
Date: Sun, 25 May 2008 11:23:08 +0900	[thread overview]
Message-ID: <20080525112308.03a5fda7.komurojun-mbn@nifty.com> (raw)

Hi,

Please revert the patch "Add a WARN_ON_ONCE() to
 the transmit timeout function".

The transmit timeout sometimes happens on normal operation.
This message annoys me.


>net: Add a WARN_ON_ONCE() to the transmit timeout function
>
>WARN_ON_ONCE() gives a stack trace including the full module list.
>Having this in the kernel dump for the timeout case in the
>generic netdev watchdog will help us see quicker which driver
>is involved. It also allows us to collect statistics
>and patterns in terms of which drivers have this event occuring.
>
>Suggested by Andrew Morton
>
>Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
>Signed-off-by: David S. Miller <davem@davemloft.net>

Best Regards
Komuro


             reply	other threads:[~2008-05-25  2:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-25  2:23 Komuro [this message]
2008-05-25 12:10 ` David Miller
2008-05-27 12:34   ` Komuro
2008-05-27 13:14     ` David Miller
2008-07-29 12:53 ` NETDEV WATCHDOG: wifi0: transmit timed out Komuro
2008-07-29 13:43   ` Justin Mattock
2008-07-29 13:58   ` Arjan van de Ven
2008-07-29 20:47     ` David Miller
2008-07-29 22:48       ` Justin Mattock
2008-07-30 11:41         ` Dan Williams
2008-07-30 11:48   ` Komuro
2008-07-30 13:22     ` Arjan van de Ven
2008-07-30 14:55       ` Justin Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080525112308.03a5fda7.komurojun-mbn@nifty.com \
    --to=komurojun-mbn@nifty.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®