From: Arjan van de Ven <arjan@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
akpm@osdl.org, Ingo Molnar <mingo@elte.hu>,
Clark Williams <clark.williams@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Gregory Haskins <ghaskins@novell.com>, Andi Kleen <ak@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: enable preemption in delay
Date: Sun, 25 May 2008 12:28:08 -0700 [thread overview]
Message-ID: <20080525122808.54f5026e@infradead.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805252100120.3295@apollo.tec.linutronix.de>
On Sun, 25 May 2008 21:01:32 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sun, 25 May 2008, Arjan van de Ven wrote:
>
> > On Sat, 24 May 2008 23:11:20 -0400 (EDT)
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > >
> > > In git commit 35d5d08a085c56f153458c3f5d8ce24123617faf, Andrew
> > > Morton placed preempt_disable around the entire delay due to
> > > TSC's not working nicely on SMP. Unfortunately for those that
> > > care about latencies this is devastating! Especially when we have
> > > callers to mdelay(8).
> >
> > we used to have a WARN_ON if mdelay was called while preemptable..
> > maybe we should put that back in?
>
> We'd better have one which warns, when mdelay is called with
> preemption disabled.
argument for my variant was "should have used msleep instead"...
I don't disagree that mdelay() is harmful in general; at some point I
stuck a WARN_ON in mdelay when called from irq context...
next prev parent reply other threads:[~2008-05-25 19:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 3:11 Steven Rostedt
2008-05-25 12:44 ` Thomas Gleixner
2008-05-25 13:07 ` Steven Rostedt
2008-05-25 13:17 ` Steven Rostedt
2008-05-25 13:19 ` Alan Cox
2008-05-25 13:40 ` Steven Rostedt
2008-05-25 20:21 ` Thomas Gleixner
2008-05-25 13:35 ` [PATCH -v2] " Steven Rostedt
2008-05-25 13:44 ` Steven Rostedt
2008-05-25 13:51 ` [PATCH -v3] " Steven Rostedt
2008-05-25 15:04 ` Steven Rostedt
2008-05-25 15:13 ` [PATCH -v4] " Steven Rostedt
2008-05-25 18:01 ` [PATCH] " Pavel Machek
2008-05-28 13:01 ` Steven Rostedt
2008-05-31 7:18 ` Pavel Machek
2008-05-25 18:53 ` Arjan van de Ven
2008-05-25 19:01 ` Thomas Gleixner
2008-05-25 19:28 ` Arjan van de Ven [this message]
2008-05-25 19:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525122808.54f5026e@infradead.org \
--to=arjan@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clark.williams@gmail.com \
--cc=ghaskins@novell.com \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®