From: Jan Kara <jack@suse.cz>
To: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VFS: Pagecache usage optimization on pagesize !=blocksize environment
Date: Mon, 26 May 2008 13:40:49 +0200 [thread overview]
Message-ID: <20080526114049.GA32407@duck.suse.cz> (raw)
In-Reply-To: <6.0.0.20.2.20080526155336.058ed7b0@172.19.0.2>
On Mon 26-05-08 16:20:10, Hisashi Hifumi wrote:
>
> > But I'm slightly confused that the patch helps because I've always
> >thought that mpage_readpage() (which is what we end up calling from
> >do_generic_mapping_read()) always reads the whole page. Thus either all
> >buffers in the page or none of them are uptodate... So what do I miss
> >here?
> >
> > Honza
>
> On ext3/4, a file is written through buffer/block. So if a page has multiple
> buffers, buffers can be uptodate partially especially under random write workloads.
> See __block_prepare_write and __block_commit_write.
Ah, I see. Thanks for explanation.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2008-05-26 11:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 6:52 [PATCH] VFS: Pagecache usage optimization on pagesize != blocksize environment Hisashi Hifumi
2008-05-21 7:19 ` Andrew Morton
2008-05-21 7:38 ` Andrew Morton
2008-05-22 7:31 ` [PATCH] VFS: Pagecache usage optimization on pagesize !=blocksize environment Hisashi Hifumi
2008-05-22 8:03 ` Andrew Morton
2008-05-22 12:08 ` [PATCH] VFS: Pagecache usage optimization on pagesize!=blocksize environment Hisashi Hifumi
2008-05-23 22:51 ` [PATCH] VFS: Pagecache usage optimization on pagesize !=blocksize environment Jan Kara
2008-05-26 7:20 ` Hisashi Hifumi
2008-05-26 11:40 ` Jan Kara [this message]
2008-05-27 8:38 ` [PATCH] VFS: Pagecache usage optimization on pagesize!=blocksize environment Hisashi Hifumi
2008-05-27 8:51 ` Andrew Morton
2008-05-27 9:34 ` [PATCH] VFS: Pagecache usage optimization onpagesize!=blocksize environment Hisashi Hifumi
2008-05-28 23:23 ` Andrew Morton
2008-06-10 1:52 ` [PATCH] VFS: Pagecache usage optimization onpagesize!=blocksizeenvironment Hisashi Hifumi
2008-07-11 23:39 ` [PATCH] VFS: Pagecache usage optimization onpagesize!=blocksize environment Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526114049.GA32407@duck.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®