From: Sebastian Siewior <lkml@ml.breakpoint.cc>
To: Toralf F?rster <toralf.foerster@gmx.de>
Cc: dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MTD: fix 2 "unused variables" warnings in drivers/mtd/nand/cafe_nand.c
Date: Mon, 26 May 2008 13:58:26 +0200 [thread overview]
Message-ID: <20080526115825.GA6722@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <200805261347.55492.toralf.foerster@gmx.de>
* Toralf F?rster | 2008-05-26 13:47:51 [+0200]:
>--- a/drivers/mtd/nand/cafe_nand.c
>+++ b/drivers/mtd/nand/cafe_nand.c
>@@ -626,9 +626,7 @@ static int __devinit cafe_nand_probe(struct pci_dev *pdev,
> {
> struct mtd_info *mtd;
> struct cafe_priv *cafe;
>- struct mtd_partition *parts;
> uint32_t ctrl;
>- int nr_parts;
> int err = 0;
>
> /* Very old versions shared the same PCI ident for all three
>@@ -800,6 +798,9 @@ static int __devinit cafe_nand_probe(struct pci_dev *pdev,
> add_mtd_device(mtd);
>
> #ifdef CONFIG_MTD_PARTITIONS
>+ struct mtd_partition *parts;
>+ int nr_parts;
>+
You can't declare variables in the middle of the code, can you?
> nr_parts = parse_mtd_partitions(mtd, part_probes, &parts, 0);
> if (nr_parts > 0) {
> cafe->parts = parts;
Sebastian
prev parent reply other threads:[~2008-05-26 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 11:47 Toralf Förster
2008-05-26 11:58 ` Sebastian Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526115825.GA6722@Chamillionaire.breakpoint.cc \
--to=lkml@ml.breakpoint.cc \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®