From: Pavel Machek <pavel@suse.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Dave Jones <davej@codemonkey.org.uk>,
Andi Kleen <andi@firstfloor.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: amd64-agp: resume but too late?
Date: Mon, 26 May 2008 20:29:04 +0200 [thread overview]
Message-ID: <20080526182904.GA13683@elf.ucw.cz> (raw)
Hi!
I don't get it:
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -549,6 +549,8 @@ static int agp_amd64_suspend(struct pci_
return 0;
}
+/* FIXME: this is strange; we enable iommu translation here, but that
+ * may be too late, no? */
static int agp_amd64_resume(struct pci_dev *pdev)
{
pci_set_power_state(pdev, PCI_D0);
...but resume is normal pci device, so other devices may be resumed
before this one, and already depend on iommu running...
How is this supposed to work? Should agp_amd64_resume be called from
sysdev or something like that?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2008-05-26 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 18:29 Pavel Machek [this message]
2008-05-27 12:18 ` Thomas Gleixner
2008-05-28 10:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526182904.GA13683@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=andi@firstfloor.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®