mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Adrian Hunter <ext-adrian.hunter@nokia.com>
Subject: Re: [PATCH take 3 29/29] UBIFS: include FS to compilation
Date: Wed, 28 May 2008 01:05:16 +0300	[thread overview]
Message-ID: <20080527220516.GD11310@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <1211810743-18936-30-git-send-email-Artem.Bityutskiy@nokia.com>

On Mon, May 26, 2008 at 05:05:43PM +0300, Artem Bityutskiy wrote:
>...
> --- /dev/null
> +++ b/fs/ubifs/Kconfig
> @@ -0,0 +1,71 @@
> +config UBIFS_FS
> +	tristate "UBIFS file system support"
> +	select CRC16
> +	select CRC32
> +	depends on MTD_UBI
> +	help
> +	  UBIFS is a file system for flash devices which works on top of UBI.
>...
> +config UBIFS_FS_LZO
> +	bool "LZO compression support" if UBIFS_FS_ADVANCED_COMPR
> +	select CRYPTO
> +	select CRYPTO_LZO
> +	depends on UBIFS_FS
> +	default y
> +	help
> +	   LZO compressor is generally faster then zlib but compresses worse.
> +	   Say 'Y' if unsure.
>...

Please change this and similar other options to:

config UBIFS_FS
	tristate "UBIFS file system support"
	select CRC16
	select CRC32
	select CRYPTO if UBIFS_FS_LZO
	select CRYPTO_LZO if UBIFS_FS_LZO
	depends on MTD_UBI
...

config UBIFS_FS_LZO
	bool "LZO compression support" if UBIFS_FS_ADVANCED_COMPR
	depends on UBIFS_FS
...


This way UBIFS_FS=m, UBIFS_FS_LZO=y will only force CRYPTO_LZO=m and not 
CRYPTO_LZO=y.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2008-05-27 22:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-26 14:05 [PATCH take 3] UBIFS - new flash file system Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 01/29] VFS: move inode_lock into sync_sb_inodes Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 02/29] VFS: export sync_sb_inodes Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 03/29] do_mounts: allow UBI root device name Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 04/29] UBIFS: add brief documentation Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 05/29] UBIFS: add I/O sub-system Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 06/29] UBIFS: add flash scanning Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 07/29] UBIFS: add journal replay Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 08/29] UBIFS: add file-system build Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 09/29] UBIFS: add superblock and master node Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 10/29] UBIFS: add file-system recovery Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 11/29] UBIFS: add compression support Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 12/29] UBIFS: add key helpers Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 13/29] UBIFS: add the journal Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 14/29] UBIFS: add commit functionality Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 15/29] UBIFS: add TNC implementation Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 16/29] UBIFS: add TNC commit implementation Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 17/29] UBIFS: add TNC shrinker Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 18/29] UBIFS: add LEB properties Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 19/29] UBIFS: add LEB properties tree Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 20/29] " Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 21/29] UBIFS: add LEB find subsystem Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 22/29] UBIFS: add Garbage Collector Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 23/29] UBIFS: add VFS operations Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 24/29] UBIFS: add budgeting Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 25/29] UBIFS: add extended attribute support Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 26/29] UBIFS: add orphans handling sub-system Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 27/29] UBIFS: add header files Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 28/29] UBIFS: add debugging stuff Artem Bityutskiy
2008-05-26 14:05 ` [PATCH take 3 29/29] UBIFS: include FS to compilation Artem Bityutskiy
2008-05-27 22:05   ` Adrian Bunk [this message]
2008-05-28  4:57     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080527220516.GD11310@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=ext-adrian.hunter@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®