From: Andrew Morton <akpm@linux-foundation.org>
To: Guillaume Chazarain <guichaz@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs-writeback: handle errors in sync_sb_inodes()
Date: Tue, 27 May 2008 22:38:32 -0700 [thread overview]
Message-ID: <20080527223832.f7131761.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080523203429.11846.84137.stgit@localhost.localdomain>
On Fri, 23 May 2008 22:34:29 +0200 Guillaume Chazarain <guichaz@gmail.com> wrote:
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 495214d..0e6881e 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -454,6 +454,7 @@ void generic_sync_sb_inodes(struct super_block *sb,
> struct address_space *mapping = inode->i_mapping;
> struct backing_dev_info *bdi = mapping->backing_dev_info;
> long pages_skipped;
> + int err;
>
> if (!bdi_cap_writeback_dirty(bdi)) {
> redirty_tail(inode);
> @@ -498,7 +499,8 @@ void generic_sync_sb_inodes(struct super_block *sb,
> BUG_ON(inode->i_state & I_FREEING);
> __iget(inode);
> pages_skipped = wbc->pages_skipped;
> - __writeback_single_inode(inode, wbc);
> + err = __writeback_single_inode(inode, wbc);
> + mapping_set_error(mapping, err);
> if (wbc->sync_mode == WB_SYNC_HOLD) {
> inode->dirtied_when = jiffies;
> list_move(&inode->i_list, &sb->s_dirty);
ho hum, I've forgotten why I didn't like this. Let's give it a run.
next prev parent reply other threads:[~2008-05-28 5:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 20:34 Guillaume Chazarain
2008-05-28 5:38 ` Andrew Morton [this message]
2008-05-28 8:18 ` Guillaume Chazarain
2008-05-28 8:25 ` Dave Chinner
2008-05-28 8:35 ` Andrew Morton
2008-05-28 8:43 ` Dave Chinner
2008-05-28 8:46 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2008-01-07 19:02 Guillaume Chazarain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527223832.f7131761.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=guichaz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome