From: thunder7@xs4all.nl
To: Jan Engelhardt <jengelh@medozas.de>
Cc: thunder7@xs4all.nl, Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: vt/fbcon: fix background color on line feed
Date: Wed, 28 May 2008 18:56:11 +0000 [thread overview]
Message-ID: <20080528185611.GA25696@wl500g> (raw)
In-Reply-To: <alpine.LNX.1.10.0805281003040.12937@fbirervta.pbzchgretzou.qr>
From: Jan Engelhardt <jengelh@medozas.de>
Date: Wed, May 28, 2008 at 07:08:30PM +0200
> commit 7f676fb7cf34dd2982d0cf79aeea7e5b06ad91eb
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Wed May 28 10:00:41 2008 +0200
>
> vt: fix background color on line feed, DEC invert
>
> Original report: """I used to force my console to black-on-white by
> the command `setterm -inversescreen on`. In 2.6.26-rc4, I get lots of
> black background characters."""
>
> Another addendum to commit c9e587ab.
> This was previously missed out since I was not aware of what
> vc_decscnm was for.
>
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
> drivers/char/vt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
> index fa1ffbf..b8b2498 100644
> --- a/drivers/char/vt.c
> +++ b/drivers/char/vt.c
> @@ -434,7 +434,7 @@ static void update_attr(struct vc_data *vc)
> vc->vc_blink, vc->vc_underline,
> vc->vc_reverse ^ vc->vc_decscnm, vc->vc_italic);
> vc->vc_video_erase_char = (build_attr(vc, vc->vc_color, 1, vc->vc_blink, 0, vc->vc_decscnm, 0) << 8) | ' ';
> - vc->vc_scrl_erase_char = (build_attr(vc, vc->vc_def_color, 1, false, false, false, false) << 8) | ' ';
> + vc->vc_scrl_erase_char = (build_attr(vc, vc->vc_def_color, 1, false, false, vc->vc_decscnm, false) << 8) | ' ';
> }
>
> /* Note: inverting the screen twice should revert to the original state */
>
Thanks, that fixes my issue with setterm -inversescreen on in
2.6.26-rc4.
Kind regards,
Jurriaan
--
"Light makes shadows. We all cast them. We'd be foolish to believe other-
wise. But that one--" She tilted her chin over her shoulder. "She darkens
those near her. She was a shadow before the sun ever touched her."
Melanie Rawn - Skybowl
prev parent reply other threads:[~2008-05-28 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 8:17 Jan Engelhardt
2008-05-27 19:33 ` thunder7
2008-05-28 17:08 ` Jan Engelhardt
2008-05-28 18:56 ` thunder7 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528185611.GA25696@wl500g \
--to=thunder7@xs4all.nl \
--cc=akpm@linux-foundation.org \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®