From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756978AbYE2Ovn (ORCPT ); Thu, 29 May 2008 10:51:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753103AbYE2Ovd (ORCPT ); Thu, 29 May 2008 10:51:33 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:51355 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbYE2Ovc (ORCPT ); Thu, 29 May 2008 10:51:32 -0400 Date: Thu, 29 May 2008 08:51:31 -0600 From: Matthew Wilcox To: Gerb Stralko Cc: James Bottomley , Andrew Morton , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi: remove CDROM not ready printk Message-ID: <20080529145131.GS22636@parisc-linux.org> References: <20080529004154.bbc7b1d4.akpm@linux-foundation.org> <1212069932.3428.1.camel@localhost.localdomain> <75b57c110805290735i493eca0fp882f4a38901a416c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75b57c110805290735i493eca0fp882f4a38901a416c@mail.gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 29, 2008 at 10:35:08AM -0400, Gerb Stralko wrote: > On Thu, May 29, 2008 at 10:05 AM, James Bottomley > wrote: > > That's correct. cgc is the data from the packet command that was sent > > in from the ioctl. The user application is actually the one that > > decides whether you get to see the message or not. Modern apps like hal > > set it because they take care of all state updates and notifications > > themselves. Which is the application that's doing this (because it > > probably needs updating). > > So is that printk really needed? Should the kernel even need to print > a message like that, esp. if user-space is handling state updates and > notifications. Or do i need to configure hald to be quietier? FWIW > I'm using fedora core 9 and hald version: > -bash-3.2$ /usr/sbin/hald --version > HAL package version: 0.5.11 I think you misunderstood. James is saying that an app like HAL will set the ->quiet flag. You must be using some other application that isn't setting the ->quiet flag. Any idea what this other application is? -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."