From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759726AbYE2X0v (ORCPT ); Thu, 29 May 2008 19:26:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755125AbYE2X0l (ORCPT ); Thu, 29 May 2008 19:26:41 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:36156 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755084AbYE2X0k (ORCPT ); Thu, 29 May 2008 19:26:40 -0400 Date: Thu, 29 May 2008 18:26:34 -0500 From: Paul Jackson To: Max Krasnyansky Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, menage@google.com, rostedt@goodmis.org, maxk@qualcomm.com Subject: Re: [PATCH] sched: Move cpu masks from kernel/sched.c into kernel/cpu.c Message-Id: <20080529182634.e9146033.pj@sgi.com> In-Reply-To: <1212085023-22284-2-git-send-email-maxk@qualcomm.com> References: <1212085023-22284-1-git-send-email-maxk@qualcomm.com> <1212085023-22284-2-git-send-email-maxk@qualcomm.com> Organization: SGI X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.12.0; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Max wrote: > kernel/cpu.c is now built for the UP kernel too, but it does not > affect the size the kernel sections. I don't think this is possible. It must affect the size. The patch moves kernel/cpu.o from being included only if CONFIG_SMP, to being included always: obj-y = sched.o fork.o exec_domain.o panic.o printk.o profile.o \ - exit.o itimer.o time.o softirq.o resource.o \ + cpu.o exit.o itimer.o time.o softirq.o resource.o \ sysctl.o capability.o ptrace.o timer.o user.o \ signal.o sys.o kmod.o workqueue.o pid.o \ rcupdate.o extable.o params.o posix-timers.o \ @@ -27,7 +27,7 @@ obj-$(CONFIG_RT_MUTEXES) += rtmutex.o obj-$(CONFIG_DEBUG_RT_MUTEXES) += rtmutex-debug.o obj-$(CONFIG_RT_MUTEX_TESTER) += rtmutex-tester.o obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o -obj-$(CONFIG_SMP) += cpu.o spinlock.o +obj-$(CONFIG_SMP) += spinlock.o The kernel/cpu.o object file is non-empty; it has size, perhaps 1 or 2 kbytes of text, and a little bit of data. So adding it to builds which disabled SMP must add to the size of the resultant kernel, by my thinking anyway. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.940.382.4214