From: Adrian Bunk <bunk@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] Werror: Remove iiEllisCleanup() as it's unused.
Date: Thu, 29 May 2008 21:28:53 +0300 [thread overview]
Message-ID: <20080529182853.GA32180@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080529181736.5396.28119.stgit@warthog.procyon.org.uk>
On Thu, May 29, 2008 at 07:17:36PM +0100, David Howells wrote:
> Remove iiEllisCleanup() as it's unused.
It is used with CONFIG_COMPUTONE=m - this empty function is kinda
pointless but you also have to remove the caller from ip2main.c if
you want to remove it.
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> drivers/char/ip2/i2ellis.c | 16 ----------------
> 1 files changed, 0 insertions(+), 16 deletions(-)
>
>
> diff --git a/drivers/char/ip2/i2ellis.c b/drivers/char/ip2/i2ellis.c
> index 3601017..a7c89d8 100644
> --- a/drivers/char/ip2/i2ellis.c
> +++ b/drivers/char/ip2/i2ellis.c
> @@ -85,22 +85,6 @@ iiEllisInit(void)
> }
>
> //******************************************************************************
> -// Function: iiEllisCleanup()
> -// Parameters: None
> -//
> -// Returns: Nothing
> -//
> -// Description:
> -//
> -// This routine performs any required cleanup of the iiEllis subsystem.
> -//
> -//******************************************************************************
> -static void
> -iiEllisCleanup(void)
> -{
> -}
> -
> -//******************************************************************************
> // Function: iiSetAddress(pB, address, delay)
> // Parameters: pB - pointer to the board structure
> // address - the purported I/O address of the board
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-05-29 18:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 18:17 [PATCH 1/6] Werror: Fix casting wrong size integer to pointer David Howells
2008-05-29 18:17 ` [PATCH 2/6] Werror: Hide epca_setup() as it's unused David Howells
2008-05-29 18:35 ` Alan Cox
2008-05-29 18:17 ` [PATCH 3/6] Werror: Remove iiEllisCleanup() " David Howells
2008-05-29 18:28 ` Adrian Bunk [this message]
2008-05-29 18:35 ` Alan Cox
2008-05-29 19:07 ` David Howells
2008-05-29 18:17 ` [PATCH 4/6] Werror: Hide warnings on static module device tables David Howells
2008-05-29 19:24 ` Adrian Bunk
2008-05-29 19:41 ` David Howells
2008-05-29 19:50 ` Adrian Bunk
2008-05-29 18:17 ` [PATCH 5/6] Werror: Remove the packed attribute from PofTimStamp_tag in the hysdn driver David Howells
2008-05-29 19:24 ` Andrew Morton
2008-05-29 18:17 ` [PATCH 6/6] Werror: Provide a configuration option to enable -Werror David Howells
2008-05-29 18:30 ` Linus Torvalds
2008-05-29 18:29 ` [PATCH 1/6] Werror: Fix casting wrong size integer to pointer Linus Torvalds
2008-05-29 18:48 ` David Howells
2008-05-29 19:19 ` Andrew Morton
2008-05-29 19:25 ` David Howells
2008-05-29 20:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529182853.GA32180@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®