From: Chris Wright <chrisw@sous-sol.org>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Chris Wright <chrisw@sous-sol.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>,
William Lee Irwin III <wli@holomorphy.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: Redzone overwritten with CONFIG_SECURITY
Date: Sat, 31 May 2008 16:24:03 -0700 [thread overview]
Message-ID: <20080531232352.GV30402@sequoia.sous-sol.org> (raw)
In-Reply-To: <20080528215107.GJ30402@sequoia.sous-sol.org>
* Chris Wright (chrisw@sous-sol.org) wrote:
> * Eric Sesterhenn (snakebyte@gmx.de) wrote:
> > Is it possible that this was caused because a file didnt
> > get rebuild correctly? I can still reproduce it with the
> > old checkout. Sorry if this causes unessecary noise :(
>
> I had wondered that, since data structures will grow w/ CONFIG_SECURITY
> set (like inode, for example). I haven't encountered a Kbuild dependency
> bug in quite a while though.
Yeah, this thing is miscompiled (thanks for the vmlinux).
$ cd /tmp/CONFIG_SECURITY-mem-corruption
$ gdb -q vmlinux
(gdb) p sizeof(struct inode)
$1 = 596
(gdb) p sizeof(struct hugetlbfs_inode_info)
$2 = 592
struct hugetlbfs_inode_info {
struct shared_policy policy;
struct inode vfs_inode;
};
The hugetlbfs_inode_info structure isn't updated with the 4 extra bytes
added from CONFIG_SECURITY to struct inode.
If you're interested in more gory details, you can look at:
$ eu-readelf -winfo vmlinux > readelf-info.out
thanks,
-chris
next prev parent reply other threads:[~2008-05-31 23:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 14:34 Eric Sesterhenn
2008-05-27 14:00 ` Eric Sesterhenn
2008-05-27 14:23 ` Vegard Nossum
2008-05-27 14:53 ` Eric Sesterhenn
2008-05-27 14:55 ` Pekka Enberg
2008-05-27 15:00 ` Pekka Enberg
2008-05-27 15:11 ` Eric Sesterhenn
2008-05-27 16:11 ` Eric Sesterhenn
2008-05-27 17:59 ` Pekka Enberg
2008-05-27 18:04 ` Christoph Lameter
2008-05-27 17:47 ` Chris Wright
2008-05-28 10:03 ` Eric Sesterhenn
2008-05-28 21:51 ` Chris Wright
2008-05-31 23:24 ` Chris Wright [this message]
2008-05-27 18:25 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080531232352.GV30402@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=snakebyte@gmx.de \
--cc=vegard.nossum@gmail.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome