From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Kosaki Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH -mm 06/12] split LRU lists into anon & file sets
Date: Sun, 1 Jun 2008 21:05:12 +0530 [thread overview]
Message-ID: <20080601153512.GA8159@balbir.in.ibm.com> (raw)
In-Reply-To: <20080529202312.447477416@redhat.com>
* Rik van Riel <riel@redhat.com> [2008-05-29 16:22:52]:
> From: Rik van Riel <riel@redhat.com>
>
> Split the LRU lists in two, one set for pages that are backed by
> real file systems ("file") and one for pages that are backed by
> memory and swap ("anon"). The latter includes tmpfs.
>
> Eventually mlocked pages will be taken off the LRUs alltogether.
> A patch for that already exists and just needs to be integrated
> into this series.
>
> This patch mostly has the infrastructure and a basic policy to
> balance how much we scan the anon lists and how much we scan
> the file lists. The big policy changes are in separate patches.
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
> Signed-off-by: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
>
Hi, Rik,
My problems with OOM continue, despite the changes incorporated into
memcontrol.c. While I am investigating the problem, the code below
seemed incorrect.
> +static inline void
> +del_page_from_active_file_list(struct zone *zone, struct page *page)
> +{
> + del_page_from_lru_list(zone, page, LRU_INACTIVE_FILE);
> }
Shouldn't this be del_page_from_lru_list(zone, page, LRU_ACTIVE_FILE)?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2008-06-01 15:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:22 [PATCH -mm 00/12] VM pageout scalability improvements (V9) Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 01/12] move isolate_lru_page() to vmscan.c Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 02/12] Use an indexed array for LRU variables Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 03/12] use an array for the LRU pagevecs Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 04/12] free swap space on swap-in/activation Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 05/12] define page_file_cache() function Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 06/12] split LRU lists into anon & file sets Rik van Riel
2008-06-01 15:35 ` Balbir Singh [this message]
2008-05-29 20:22 ` [PATCH -mm 07/12] second chance replacement for anonymous pages Rik van Riel
2008-06-01 20:04 ` Balbir Singh
2008-05-29 20:22 ` [PATCH -mm 08/12] add some sanity checks to get_scan_ratio Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 09/12] fix pagecache reclaim referenced bit check Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 10/12] add newly swapped in pages to the inactive list Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 11/12] more aggressively use lumpy reclaim Rik van Riel
2008-05-29 20:22 ` [PATCH -mm 12/12] pageflag helpers for configed-out flags Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601153512.GA8159@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®