From: David Miller <davem@davemloft.net>
To: y-goto@jp.fujitsu.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: sparc64 bootup regression...
Date: Tue, 03 Jun 2008 15:14:16 -0700 (PDT) [thread overview]
Message-ID: <20080603.151416.266389541.davem@davemloft.net> (raw)
In-Reply-To: <20080430213831.F808.E1E9C6FF@jp.fujitsu.com>
From: Yasunori Goto <y-goto@jp.fujitsu.com>
Date: Wed, 30 Apr 2008 21:53:18 +0900
> I'll reconsider around here.
I think I know at least one of the problems in this change.
This code assumes that it can take __pa() on NODE_DATA().
But, if NUMA is disabled, NODE_DATA() is &contig_page_data which is a
kernel image symbol. __pa() is not supported for such addresses.
It happens to work on x86, but it will not work on just about every
other platform.
There are several things to consider to fix this changeset and
get it back into a state where it can be resubmitted into the
tree:
1) What is the goal here wrt. allocating the usemap when NUMA
is disabled.
2) What is appropriate if section_nr targetted allocation of
the usemap fails.
It seems to me that the pgdat and usemap should be allocated
together if putting them into the same section is important.
This allows us to avoid case #2 completely, and therefore we
don't even need to consider how to handle such a failure.
next prev parent reply other threads:[~2008-06-03 22:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 6:12 David Miller
2008-04-30 6:38 ` Andrew Morton
2008-04-30 6:46 ` KAMEZAWA Hiroyuki
2008-04-30 7:15 ` KAMEZAWA Hiroyuki
2008-04-30 7:25 ` David Miller
2008-04-30 7:33 ` KAMEZAWA Hiroyuki
2008-04-30 12:53 ` Yasunori Goto
2008-06-03 22:14 ` David Miller [this message]
2008-06-04 5:05 ` Yasunori Goto
2008-04-30 7:30 ` Heiko Carstens
2008-04-30 7:44 ` KAMEZAWA Hiroyuki
2008-04-30 7:45 ` Heiko Carstens
2008-04-30 7:19 ` David Miller
2008-05-07 22:09 ` Rafael J. Wysocki
2008-05-07 22:25 ` Andrew Morton
2008-05-07 22:32 ` Rafael J. Wysocki
2008-05-07 22:46 ` David Miller
2008-05-01 5:13 ` powerpc boot regression Tony Breeds
2008-05-01 14:51 ` Badari Pulavarty
2008-05-01 19:01 ` Geoff Levand
2008-05-01 23:07 ` Tony Breeds
2008-05-03 12:05 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603.151416.266389541.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®