From: Nick Piggin <npiggin@suse.de>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Petr Tesarik <ptesarik@suse.cz>, Christoph Hellwig <hch@lst.de>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: Why is the rewritten ramdisk driver called brd instad of rd
Date: Wed, 4 Jun 2008 17:18:42 +0200 [thread overview]
Message-ID: <20080604151842.GA30484@wotan.suse.de> (raw)
In-Reply-To: <alpine.LNX.1.10.0806031309350.4055@fbirervta.pbzchgretzou.qr>
On Tue, Jun 03, 2008 at 01:09:55PM +0200, Jan Engelhardt wrote:
>
> On Wednesday 2008-05-28 08:11, Nick Piggin wrote:
>
> >On Tue, May 27, 2008 at 11:28:00AM +0200, Petr Tesarik wrote:
> >> On Fri, 2008-03-21 at 14:05 +0100, Christoph Hellwig wrote:
> >> > Any reason why the rewritten ramdisk driver has a new name? It's for
> >> > all matters an inplace replacement of the old rd driver so it should
> >> > be called rd.c / rd.ko to not confused instaler/developers/etc.
> >>
> >> I think it's because the old rd played some dirty tricks with the page
> >> cache, while the reworked one is a straightforward implementation of a
> >> normal _b_lock device -> hence the "b".
> >>
> >> No guarantee of correctness.
> >
> >Yeah it was a rwrite from scratch and it lived with the rd.c code for
> >a while (although maybe never in mainline). I guess it might be good
> >idea to rename it back to rd?
>
> Just add a MODULE_ALIAS("rd").
Couldn't hurt... shall we merge this, then?
Alias brd to rd in the hope of helping legacy users. Suggested by Jan.
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/drivers/block/brd.c
===================================================================
--- linux-2.6.orig/drivers/block/brd.c 2008-06-05 00:51:53.000000000 +1000
+++ linux-2.6/drivers/block/brd.c 2008-06-05 00:52:43.000000000 +1000
@@ -397,6 +397,7 @@ module_param(max_part, int, 0);
MODULE_PARM_DESC(max_part, "Maximum number of partitions per RAM disk");
MODULE_LICENSE("GPL");
MODULE_ALIAS_BLOCKDEV_MAJOR(RAMDISK_MAJOR);
+MODULE_ALIAS("rd");
#ifndef MODULE
/* Legacy boot options - nonmodular */
prev parent reply other threads:[~2008-06-04 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 13:05 Christoph Hellwig
2008-05-27 9:28 ` Petr Tesarik
2008-05-28 6:11 ` Nick Piggin
2008-06-03 11:09 ` Jan Engelhardt
2008-06-04 15:18 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604151842.GA30484@wotan.suse.de \
--to=npiggin@suse.de \
--cc=hch@lst.de \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ptesarik@suse.cz \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®