mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Strip stray space in log message
Date: Wed, 4 Jun 2008 16:42:15 +0200	[thread overview]
Message-ID: <200806041642.15522.jdelvare@suse.de> (raw)
In-Reply-To: <20080604150158.17a33e69@core>

Hi Alan,

Le mercredi 04 juin 2008, Alan Cox a écrit :
> On Wed, 4 Jun 2008 15:38:53 +0200
> Jean Delvare <jdelvare@suse.de> wrote:
> 
> > Strip a stray space in log messages of 3 watchdog drivers.
> > (And fold these long lines to make checkpatch.pl happy.)
> 
> Don't break up strings of quoted text - it makes grepping for them much
> harder.

As written above, checkpatch.pl told me to break them up.

CodingStyle says: "Long strings are as well broken into shorter
strings." And quite rightly so IMHO, if you have to rely on grepping
the whole kernel tree to find out where a log message comes from, it
means that this log message is bad and needs to be improved.

Thanks,
-- 
Jean Delvare
Suse L3

      reply	other threads:[~2008-06-04 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 13:38 Jean Delvare
2008-06-04 14:01 ` Alan Cox
2008-06-04 14:42   ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806041642.15522.jdelvare@suse.de \
    --to=jdelvare@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®