From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762272AbYFDXCr (ORCPT ); Wed, 4 Jun 2008 19:02:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753280AbYFDXCi (ORCPT ); Wed, 4 Jun 2008 19:02:38 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:37011 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbYFDXCi (ORCPT ); Wed, 4 Jun 2008 19:02:38 -0400 Date: Thu, 5 Jun 2008 01:03:26 +0200 From: Pavel Machek To: =?iso-8859-1?Q?=C9ric?= Piel Cc: Andrew Morton , Dmitry Torokhov , Arjan van de Ven , "Mark M. Hoffman" , Yan Burman , LKML , HWMON Subject: Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Message-ID: <20080604230326.GA30475@elf.ucw.cz> References: <1212235533.3815.5.camel@localhost> <4846EBF5.2030406@tremplin-utc.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4846EBF5.2030406@tremplin-utc.net> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > We haven't received any review for this driver since last week's post by > Yan :-( That's why I'm adding explicitly as receivers of this email all > the people who have reviewed the first two previous takes. Apologies for > the possible multiple receptions. > > It would be _really really kind_ if some of you could take some time and > comment (or simply ACK ;-) ) this code. It adds support for hardware > which can be found in mostly every HP Compaq laptop less than three > years old. It's quite worthy. It looked pretty much okay on _very_ quick look. > > 3) Makes it possible to power the device off. But this part is what I don't understand. powering off does not seem to belong there. Why can't you just use acpi to power down? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html