From: Sam Ravnborg <sam@ravnborg.org>
To: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Peter Oberparleiter <oberparleiter@googlemail.com>
Subject: Re: [PATCH] kbuild: simplify module versioning procedure
Date: Thu, 5 Jun 2008 14:17:51 +0200 [thread overview]
Message-ID: <20080605121751.GA18634@uranus.ravnborg.org> (raw)
In-Reply-To: <48442052.6080506@de.ibm.com>
Hi Peter.
On Mon, Jun 02, 2008 at 06:31:14PM +0200, Peter Oberparleiter wrote:
> This patch used to be part of the gcov patch set but is no longer
> required. kbuild simplifications might still prove useful though.
It looks like a simplification but there is actually a reason why
it is done with a temporary fil in this way.
Consider a kernel build that is being terminated with ctrl-c
in the middle. If we when ctrl-c are hit are doing the final
steps of genksyms then we will next time we type make
consider all done and we will not redo the modversioning
part of the rule because we have an updated .o file.
We have this issue in other places in the build system but
I have not audited the use of redirects yet.
But applying your patch would introduce yet another place where we
have such an issue and we want to get rid of the spots
where hitting ctrl-c can leave us with an inconsistent build.
So I will not apply this patch.
Sam
prev parent reply other threads:[~2008-06-05 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 16:31 Peter Oberparleiter
2008-06-05 12:17 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605121751.GA18634@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oberparleiter@googlemail.com \
--cc=peter.oberparleiter@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®