From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>
To: linux-kernel@vger.kernel.org
Cc: "Nakajima, Jun" <jun.nakajima@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [RFC] quirk_ich4_lpc_acpi() clarification
Date: Sat, 7 Jun 2008 18:49:50 +0200 [thread overview]
Message-ID: <200806071849.51192.stefan.bauer@cs.tu-chemnitz.de> (raw)
Hi,
I was wondering why my quite ancient i815-based machine with ICH (not ICH4)
southbridge told me on startup:
pci 0000:00:1f.0: quirk: region 4000-407f claimed by ICH4 ACPI/GPIO/TCO
pci 0000:00:1f.0: quirk: region 4080-40bf claimed by ICH4 GPIO
Some search brought up that this quirk was originally registered for ICH4 and
ICH5 [1], but later extended to apply for ICH to ICH3, too [2].
The comment added by Linus in [2], telling "Intel LPC interface bridges all
have 128 bytes of magic ACPI/TCO regs and 64 bytes of GPIO", unfortunately
got lost with [3].
So in current state we have some uncertainty: Does "all" mean "all until now"
or "all ever using LPC"? In the last case not only comments, but also
DECLARE_PCI_FIXUP_HEADERs for the past-ICH5 chipsets would be missing.
I would like to fix this by...
- mentioning all affected ICHs in the comment
- probably give a better 'name' parameter then "ICH4 ..." to quirk_io_region()
- probably rename quirk_ich4_lpc_acpi()
- add DECLARE_PCI_FIXUP_HEADERs for eventually missing devices
But I need some information, especially if past-ICH5 southbridges have got
this quirk, too.
Regards, Stefan Bauer
[1] Add a quirk for the Intel ICH-[45] to add special ACPI regions.
http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=blobdiff;f=drivers/pci/quirks.c;h=0fe0f7656939ba8b2b55e55d2ac4fbe12dee59fa;hp=29313362a8b663ee85a43bcd7f70220bd64598e4;hb=0b7baee8e18d8d309b3918769fc4b60dc075baa5;hpb=7886b5151d14bde184e490201ad51a3f413df8d9
[2] All the Intel LPC bridges have the same PCI quirks.
http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=blobdiff;f=drivers/pci/quirks.c;h=b82a1c31e1df64a8aedb5c868d4e62979cc5fc19;hp=2a2a2f11f3d1a6732c4d119efc62cf74a174b4f8;hb=ca2a9e5a6a068b446ba0829385f9785695df9182;hpb=3b4871d830f2ace4c6dafe33272e0bb2ec8f83fb
[3] Merge http://nfsclient.bkbits.net/linux-2.6
http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=blobdiff;f=drivers/pci/quirks.c;h=164f738df6a7cb1c58f1033382530780a211e039;hp=6e7c350133becd05268d1cb6fa6073019c63457b;hb=ee66a188d8cd63c8baf60f7be2a24faf9d556bbd;hpb=9a1ad97be320d53eba3cdb6a69fbbea27a862461
reply other threads:[~2008-06-07 17:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806071849.51192.stefan.bauer@cs.tu-chemnitz.de \
--to=stefan.bauer@cs.tu-chemnitz.de \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®