From: Pavel Machek <pavel@suse.cz>
To: Alan Stern <stern@rowland.harvard.edu>,
Linus Torvalds <torvalds@osdl.org>
Cc: gregkh@suse.de, Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on
Date: Sat, 7 Jun 2008 21:52:22 +0200 [thread overview]
Message-ID: <20080607195221.GB11109@ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0806061030210.2354-100000@iolanthe.rowland.org>
On Fri 2008-06-06 10:39:19, Alan Stern wrote:
> On Fri, 6 Jun 2008, Pavel Machek wrote:
>
> > Hi!
> >
> > In 2.6.26-rc5,
> >
> > -config USB_PERSIST
> > - bool "USB device persistence during system suspend (DANGEROUS)"
> >
> > is now on. Given that it was previously marked "DANGEROUS", that seems
> > quite a change to me.
>
> It is. Basically I did it because Linus asked for it -- or at least,
> for something like it. He felt that the danger of not having
> USB_PERSIST when you need it is worse than the danger of having it when
> you don't want it.
Well, not-usb-persists means we force-unplug disks during suspend,
after syncing them. Not _too_ bad.
If you unplug disk while hibernated, modify it, and plug it back,
youget _silent_ filesystem corruption. I call that bad.
> > Besides, it seems to have broken usblp hibernation support, and maybe
> > other devices that does not have reset_resume() present. (Big thanks
> > for Oliver for doing investigation).
>
> URL? It's hard to see how lack of reset-resume support would mess
> anything up worse than it would be without USB_PERSIST.
usblp driver sets 'suspended' flag in .suspend(), and resets it in
.resume() -- except that with USB_PERSIST .resume() is not called :-(.
I have novell bugzilla bug number somewhere...
> > [Or is it that now USB_PERSIST is conditional on /sys fs setting, so
> > while setting it on individual device is dangerous, it is still N by
> > default? Changelog does not tell me...?]
>
> USB_PERSIST is (and has always been) conditional on the power/persist
> sysfs attribute setting. The difference is that now the setting starts
> out as On whereas before it started out as Off, and there no longer is
> a Kconfig option to remove USB_PERSIST entirely.
I consider the default to be dangerous here.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-06-07 19:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 9:25 Pavel Machek
2008-06-06 14:39 ` Alan Stern
2008-06-07 19:52 ` Pavel Machek [this message]
2008-06-07 22:26 ` Linus Torvalds
2008-06-09 8:00 ` Pavel Machek
2008-06-09 15:03 ` Alan Stern
2008-06-09 15:12 ` Oliver Neukum
2008-06-09 15:44 ` Alan Stern
2008-06-09 19:50 ` Greg KH
2008-06-09 20:59 ` Pavel Machek
2008-06-09 21:39 ` Linus Torvalds
2008-06-09 21:52 ` Oliver Neukum
2008-06-09 21:56 ` Pavel Machek
2008-06-09 22:19 ` Linus Torvalds
2008-06-10 8:55 ` Oliver Neukum
2008-06-10 14:59 ` Alan Stern
2008-06-10 15:50 ` Linus Torvalds
2008-06-10 16:36 ` Linus Torvalds
2008-06-10 18:59 ` [PATCH] USB: don't use reset-resume if drivers don't support it Alan Stern
2008-06-10 19:10 ` Linus Torvalds
2008-06-10 21:30 ` Greg KH
2008-06-10 21:42 ` patch usb-don-t-use-reset-resume-if-drivers-don-t-support-it.patch added to gregkh-2.6 tree gregkh
2008-06-09 19:56 ` 2.6.25-rc6: CONFIG_USB_PERSIST forced on Oliver Neukum
2008-06-09 15:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080607195221.GB11109@ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®