From: Bernhard Walle <bwalle@suse.de>
To: kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, vgoyal@redhat.com, anderson@redhat.com
Subject: [patch 1/3] Add return value to reserve_bootmem_node()
Date: Sun, 08 Jun 2008 15:46:29 +0200 [thread overview]
Message-ID: <20080608134629.414662758@halley.suse.de> (raw)
In-Reply-To: <20080608134628.757299158@halley.suse.de>
[-- Attachment #1: reserve-bootmem-node-return --]
[-- Type: text/plain, Size: 1340 bytes --]
This patch changes the function reserve_bootmem_node() from void to int,
returning -ENOMEM if the allocation fails.
Signed-off-by: Bernhard Walle <bwalle@suse.de>;
---
include/linux/bootmem.h | 2 +-
mm/bootmem.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
--- a/include/linux/bootmem.h
+++ b/include/linux/bootmem.h
@@ -94,7 +94,7 @@ extern unsigned long init_bootmem_node(p
unsigned long freepfn,
unsigned long startpfn,
unsigned long endpfn);
-extern void reserve_bootmem_node(pg_data_t *pgdat,
+extern int reserve_bootmem_node(pg_data_t *pgdat,
unsigned long physaddr,
unsigned long size,
int flags);
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -442,15 +442,17 @@ unsigned long __init init_bootmem_node(p
return init_bootmem_core(pgdat, freepfn, startpfn, endpfn);
}
-void __init reserve_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
+int __init reserve_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
unsigned long size, int flags)
{
int ret;
ret = can_reserve_bootmem_core(pgdat->bdata, physaddr, size, flags);
if (ret < 0)
- return;
+ return -ENOMEM;
reserve_bootmem_core(pgdat->bdata, physaddr, size, flags);
+
+ return 0;
}
void __init free_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
next prev parent reply other threads:[~2008-06-08 13:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 13:46 [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines Bernhard Walle
2008-06-08 13:46 ` Bernhard Walle [this message]
2008-06-08 13:46 ` [patch 2/3] Add flags parameter to reserve_bootmem_generic() Bernhard Walle
2008-06-08 14:26 ` WANG Cong
2008-06-08 17:12 ` Bernhard Walle
2008-06-08 22:01 ` Johannes Weiner
2008-06-09 13:22 ` Vivek Goyal
2008-06-09 16:23 ` Bernhard Walle
2008-06-09 16:39 ` Andi Kleen
2008-06-09 19:50 ` Amul Shah
2008-06-09 20:17 ` Bernhard Walle
2008-06-09 20:29 ` Vivek Goyal
2008-06-09 20:42 ` Bernhard Walle
2008-06-09 20:54 ` Vivek Goyal
2008-06-09 20:57 ` Bernhard Walle
2008-06-09 21:00 ` Vivek Goyal
2008-06-09 21:04 ` Bernhard Walle
2008-06-09 16:25 ` Bernhard Walle
2008-06-08 22:06 ` Johannes Weiner
2008-06-09 16:37 ` Bernhard Walle
2008-06-08 13:46 ` [patch 3/3] Use reserve_bootmem_generic() to reserve crashkernel memory on x86_64 Bernhard Walle
2008-06-09 13:06 ` [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines Vivek Goyal
2008-06-10 12:44 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080608134629.414662758@halley.suse.de \
--to=bwalle@suse.de \
--cc=anderson@redhat.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®