From: Andi Kleen <andi@firstfloor.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: andi@firstfloor.org, grundler@google.com, muli@il.ibm.com,
linux-kernel@vger.kernel.org, mgross@linux.intel.com,
linux-scsi@vger.kernel.org
Subject: Re: Intel IOMMU (and IOMMU for Virtualization) performances
Date: Mon, 9 Jun 2008 12:20:25 +0200 [thread overview]
Message-ID: <20080609102025.GB21661@one.firstfloor.org> (raw)
In-Reply-To: <20080609184052Z.fujita.tomonori@lab.ntt.co.jp>
On Mon, Jun 09, 2008 at 06:36:29PM +0900, FUJITA Tomonori wrote:
> On Mon, 09 Jun 2008 10:17:11 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > "Grant Grundler" <grundler@google.com> writes:
> > >
> > > The historical DMA mapping "failure mode" is a kernel panic. Resizing or
> >
> > Hasn't been for a long time, except in some extreme cases. All drivers
> > are expected to check return values for a long time now.
>
> Agreed, but I think that lots of network drivers still assume that DMA
> mapping always succeeds (they don't check return values).
Those should be just fixed.
You're right. I reviewed some new drivers and was surprised that they
even got that wrong (code reviewers were supposed to flag this in the
first place)
I would guess in practice the main offender would be tg3.c/bnx2.c.
On the other hand Intel IOMMU systems should usually use e1000e which
checks.
-Andi
next prev parent reply other threads:[~2008-06-09 10:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 14:47 FUJITA Tomonori
2008-06-04 16:56 ` Andi Kleen
2008-06-05 14:49 ` FUJITA Tomonori
2008-06-04 18:06 ` Grant Grundler
2008-06-05 14:49 ` FUJITA Tomonori
2008-06-05 18:34 ` Grant Grundler
2008-06-05 19:01 ` James Bottomley
2008-06-06 4:44 ` FUJITA Tomonori
2008-06-06 5:48 ` Grant Grundler
2008-06-09 9:36 ` FUJITA Tomonori
2008-06-06 20:23 ` Muli Ben-Yehuda
2008-06-06 20:21 ` Muli Ben-Yehuda
2008-06-06 21:28 ` Grant Grundler
2008-06-06 21:36 ` Muli Ben-Yehuda
2008-06-06 21:51 ` Grant Grundler
2008-06-09 8:17 ` Andi Kleen
2008-06-09 9:36 ` FUJITA Tomonori
2008-06-09 10:20 ` Andi Kleen [this message]
2008-06-05 22:02 ` mark gross
2008-06-06 4:44 ` FUJITA Tomonori
2008-06-23 17:54 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609102025.GB21661@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=grundler@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®