From: Arjan van de Ven <arjan@infradead.org>
To: "Rakib Mullick" <rakib.mullick@gmail.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] resend Removes PID_MAX_DEFAULT.
Date: Tue, 10 Jun 2008 07:22:14 -0700 [thread overview]
Message-ID: <20080610072214.56bd3506@infradead.org> (raw)
In-Reply-To: <b9df5fa10806100050j684db890wc48ef0596ee95719@mail.gmail.com>
On Tue, 10 Jun 2008 13:50:26 +0600
"Rakib Mullick" <rakib.mullick@gmail.com> wrote:
> This removes use of PID_MAX_DEFAULT. please reply.
Hi,
can I ask why?
can you explain what is wrong with the original? To me it's a bit weird
to move this from a central location to 2 other places....
>
> Signed-off-by: Md. Rakib Hassan Mullick (rakib.mullick@gmail.com)
> ---
> diff -upr linux-2.6.25-vanilla/include/linux/threads.h
> linux-2.6.25/include/linux/threads.h
> --- linux-2.6.25-vanilla/include/linux/threads.h 2008-04-17
> 08:49:44.000000000 +0600
> +++ linux-2.6.25/include/linux/threads.h 2008-06-07
> 18:46:29.000000000 +0600 @@ -22,15 +22,10 @@
> #define MIN_THREADS_LEFT_FOR_ROOT 4
>
> /*
> - * This controls the default maximum pid allocated to a process
> - */
> -#define PID_MAX_DEFAULT (CONFIG_BASE_SMALL ? 0x1000 : 0x8000)
> -
> -/*
> * A maximum of 4 million PIDs should be enough for a while.
> * [NOTE: PID/TIDs are limited to 2^29 ~= 500+ million, see futex.h.]
> */
> #define PID_MAX_LIMIT (CONFIG_BASE_SMALL ? PAGE_SIZE * 8 : \
> - (sizeof(long) > 4 ? 4 * 1024 * 1024 : PID_MAX_DEFAULT))
> + (sizeof(long) > 4 ? 4 * 1024 * 1024 : (CONFIG_BASE_SMALL ?
> 0x1000 : 0x8000)))
>
> #endif
> diff -upr linux-2.6.25-vanilla/kernel/pid.c linux-2.6.25/kernel/pid.c
> --- linux-2.6.25-vanilla/kernel/pid.c 2008-04-17
> 08:49:44.000000000 +0600 +++ linux-2.6.25/kernel/pid.c
> 2008-06-07 18:46:25.000000000 +0600 @@ -42,7 +42,10 @@ static struct
> hlist_head *pid_hash; static int pidhash_shift;
> struct pid init_struct_pid = INIT_STRUCT_PID;
>
> -int pid_max = PID_MAX_DEFAULT;
> +/*
> + * This controls the default maximum pid allocated to a process
> + */
> +int pid_max = CONFIG_BASE_SMALL ? 0x1000 : 0x8000 ;
>
> #define RESERVED_PIDS 300
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
prev parent reply other threads:[~2008-06-10 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 7:50 Rakib Mullick
2008-06-10 14:22 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610072214.56bd3506@infradead.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®