From: Jack Steiner <steiner@sgi.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
tglx@linutronix.de, holt@sgi.com, andrea@qumranet.com
Subject: Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes
Date: Tue, 10 Jun 2008 09:41:54 -0500 [thread overview]
Message-ID: <20080610144154.GA29042@sgi.com> (raw)
In-Reply-To: <adaod6a70mq.fsf@cisco.com>
On Mon, Jun 09, 2008 at 02:35:09PM -0700, Roland Dreier wrote:
> > +EXTRA_CFLAGS += -DDEBUG -Werror -Wall
>
> Not sure if it's appropriate to set these flags for your driver...
Deleted. This was primarily for debugging. I moved the DEBUG option to
Kconfig as a driver DEBUG option that can be selected.
>
> > + ---help---
> > + This option enables basic support for the SGI UV GRU driver. If
> > + you are not running on a SGI UV system, say N.
>
> "...enables basic support for the SGI UV GRU." And it would be a good
> idea to include some info about what UV GRU does -- your 0/11
> introduction mail had a good description that would be nice to have here
> as well.
Done
--- jack
next prev parent reply other threads:[~2008-06-10 14:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 21:10 [patch 00/11] GRU Driver steiner
2008-06-09 21:10 ` [patch 01/11] GRU Driver - hardware data structures steiner
2008-06-09 22:52 ` Andrew Morton
2008-06-10 4:07 ` Andi Kleen
2008-06-11 18:57 ` Jack Steiner
2008-06-09 21:10 ` [patch 02/11] GRU Driver - GRU instructions & macros steiner
2008-06-09 21:10 ` [patch 03/11] GRU Driver - driver internal header files steiner
2008-06-09 21:38 ` Roland Dreier
2008-06-10 14:57 ` Jack Steiner
2008-06-09 21:10 ` [patch 04/11] GRU Driver - kernel services " steiner
2008-06-09 21:10 ` [patch 05/11] GRU Driver - driver initialization, file & vma ops steiner
2008-06-09 21:10 ` [patch 06/11] GRU Driver - page faults & exceptions steiner
2008-06-09 21:10 ` [patch 07/11] GRU Driver - kernel services provide by driver steiner
2008-06-09 21:10 ` [patch 08/11] GRU Driver - resource management steiner
2008-06-09 21:10 ` [patch 09/11] GRU Driver - /proc interfaces steiner
2008-06-09 21:32 ` Roland Dreier
2008-06-09 22:11 ` Jack Steiner
2008-06-10 14:20 ` Roland Dreier
2008-06-09 21:10 ` [patch 10/11] GRU Driver - TLB flushing, MMUOPS callouts steiner
2008-06-09 21:10 ` [patch 11/11] GRU Driver - makefile & Kconfig file changes steiner
2008-06-09 21:35 ` Roland Dreier
2008-06-10 14:41 ` Jack Steiner [this message]
2008-06-12 13:27 ` [patch 00/11] GRU Driver Ingo Molnar
2008-06-12 14:05 ` Jack Steiner
2008-06-12 18:03 ` Andrew Morton
2008-06-12 20:52 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610144154.GA29042@sgi.com \
--to=steiner@sgi.com \
--cc=akpm@osdl.org \
--cc=andrea@qumranet.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome