From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.25.6
Date: Tue, 10 Jun 2008 20:06:45 -0300 [thread overview]
Message-ID: <20080610230645.GA16711@khazad-dum.debian.net> (raw)
In-Reply-To: <20080610195747.GA18926@martell.zuzino.mipt.ru>
On Tue, 10 Jun 2008, Alexey Dobriyan wrote:
> Person fixing a bug may not realize he fixes security-sensitive bug.
That is a valid reason, I am pretty sure everyone here (including me) has
been guilty of that one. Which doesn't mean we can't do better to educate
ourselves on the patterns for the most common issues. The "fix for a
null-dereference to anything that has a function pointer in it" is such a
pattern.
> Or simply doesn't care because there are 5 more to fix for today.
THAT, however, is unacceptable IMO. If one can't be bothered, or one
doesn't have the time (or the skill, whatever) to access the severity of a
fix, he should ask for someone to do that on the commit message. One extra
short sentence at the end of the commit message [asking for that help] is
DEFINATELY not too much to ask.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-06-10 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 19:49 Chris Wright
2008-06-09 19:49 ` Chris Wright
2008-06-10 14:53 ` Henrique de Moraes Holschuh
2008-06-10 19:17 ` markus reichelt
2008-06-10 19:57 ` Alexey Dobriyan
2008-06-10 23:06 ` Henrique de Moraes Holschuh [this message]
2008-06-11 6:28 ` Alexey Dobriyan
2008-06-10 20:12 ` Chris Wright
2008-06-10 23:10 ` Willy Tarreau
2008-06-10 23:20 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610230645.GA16711@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®