mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Suresh B Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH 0/5] x86: minor PAT adaptations
Date: Thu, 12 Jun 2008 10:10:29 +0200	[thread overview]
Message-ID: <20080612081029.GA1403@elte.hu> (raw)
In-Reply-To: <20080610140411.GD5024@alberich.amd.com>


* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> Following some patches to slightly adapt the PAT code.
> 
> patch 1 - enable PAT for all AMD CPUs that have the PAT feature flag set
> patch 2 - fix up paranoia check in pat_init and fix the logic to
>           enable/disable PAT (IMHO the current code enables PAT on all
>           Transmeta and Centaur CPUs even if no PAT feature flag is set) 
>           (I admit I should have changed the sequence of patches 1 and 2.)
> patch 3 - fix some checkpatch errors
> patch 4 - variable renaming

applied to tip/x86/pat, thanks Andreas. (i presume you'll send a 
followup patch for the suggestions that came up in the discussion)

> patch 5 - slightly changing the code that is doing the intersection of
>           pat_type and mtrr_type to be more readable (from my point of view)
> 
> Patches are against x86/pat (as of version v2.6.26-rc3-6-g46dd98a).

#5 makes sense too, but it didnt apply cleanly:

 Applying patch 
 patches/pat-x86-pat-make-pat-x-mtrr-type-more-readable.patch
 patching file arch/x86/mm/pat.c
 Hunk #1 FAILED at 185.
 1 out of 1 hunk FAILED -- rejects in file arch/x86/mm/pat.c

(it didnt apply neither against tip/x86/pat or tip/master, nor against 
linus/master. I guess it's some mixup somewhere.)

	Ingo

  reply	other threads:[~2008-06-12  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 14:04 Andreas Herrmann
2008-06-12  8:10 ` Ingo Molnar [this message]
2008-06-12 10:01   ` Andreas Herrmann
2008-06-12 10:57     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080612081029.GA1403@elte.hu \
    --to=mingo@elte.hu \
    --cc=andreas.herrmann3@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®