From: Louis Rilling <Louis.Rilling@kerlabs.com>
To: Joel Becker <joel.becker@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com,
teigland@redhat.com
Subject: Re: [RFC] configfs: Allow ->make_item() and ->make_group() to return detailed errors.
Date: Fri, 13 Jun 2008 00:38:03 +0200 [thread overview]
Message-ID: <20080612223803.GB4012@localdomain> (raw)
In-Reply-To: <1213305595-16805-1-git-send-email-joel.becker@oracle.com>
On Thu, Jun 12, 2008 at 02:19:55PM -0700, Joel Becker wrote:
> The configfs operations ->make_item() and ->make_group() currently
> return a new item/group. A return of NULL signifies an error. Because
> of this, -ENOMEM is the only return code bubbled up the stack.
>
> Multiple folks have requested the ability to return specific error codes
> when these operations fail. This patch adds that ability by changing the
> ->make_item/group() ops to return an int.
>
> Also updated are the in-kernel users of configfs.
>
> Signed-off-by: Joel Becker <joel.becker@oracle.com>
Looks good to me. Happy to see this change coming :)
Louis
--
Dr Louis Rilling Kerlabs - IRISA
Skype: louis.rilling Campus Universitaire de Beaulieu
Phone: (+33|0) 2 99 84 71 52 Avenue du General Leclerc
Fax: (+33|0) 2 99 84 71 71 35042 Rennes CEDEX - France
http://www.kerlabs.com/
prev parent reply other threads:[~2008-06-12 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 21:19 Joel Becker
2008-06-12 22:38 ` Louis Rilling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080612223803.GB4012@localdomain \
--to=louis.rilling@kerlabs.com \
--cc=cluster-devel@redhat.com \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®