From: Greg KH <gregkh@suse.de>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kobject: should use kobject_put() in kset-example
Date: Thu, 12 Jun 2008 20:39:29 -0700 [thread overview]
Message-ID: <20080613033929.GB17115@suse.de> (raw)
In-Reply-To: <4851E4DC.6040603@cn.fujitsu.com>
On Fri, Jun 13, 2008 at 11:09:16AM +0800, Li Zefan wrote:
> We should call kobject_put() instead of kfree() if kobject_init_and_add()
> returns an error, shouldn't we? Don't set up a bad example ;)
Ah, good catch, you are right. I'll go add this to my queue, thanks for
the patch.
greg k-h
prev parent reply other threads:[~2008-06-13 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 3:09 Li Zefan
2008-06-13 3:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080613033929.GB17115@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®