mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: [PATCH] cputopology: Always define CPU topology information [5th try]
Date: Fri, 13 Jun 2008 11:15:40 +0100	[thread overview]
Message-ID: <20080613101539.GV11300@solarflare.com> (raw)
In-Reply-To: <20080613051654.GC21586@elte.hu>

Ingo Molnar wrote:
> 
> * Ben Hutchings <bhutchings@solarflare.com> wrote:
> 
> > Not all architectures and configurations define CPU topology 
> > information. This can result in an empty topology directory in sysfs, 
> > and requires in-kernel users to protect all uses with #ifdef - see 
> > <http://marc.info/?l=linux-netdev&m=120639033904472&w=2>.
> > 
> > The documentation of CPU topology specifies what the defaults should 
> > be if only partial information is available from the hardware.  So we 
> > can provide these defaults as a fallback.
> > 
> > This patch:
> > 
> > - Adds default definitions of the 4 topology macros to <linux/topology.h>
> > - Changes drivers/base/topology.c to use the topology macros unconditionally
> > - Updates documentation accordingly
> 
> applied to tip/core/topology - thanks Ben.

Unfortunately you lost the first paragraph of the commit message, then
created a second commit (difference between 4th and 5th versions) with
your own commit message and me as the author.  Maybe it's nitpicking but I
would prefer to have strictly accurate metadata in the commit log.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.

  reply	other threads:[~2008-06-13 10:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 15:44 [PATCH] cputopology: Always define CPU topology information [4th try] Ben Hutchings
2008-06-05  4:47 ` Andrew Morton
2008-06-05 12:08   ` Ben Hutchings
2008-06-05 16:28     ` Andrew Morton
2008-06-05 16:37       ` [PATCH] cputopology: Always define CPU topology information [5th try] Ben Hutchings
2008-06-13  5:16         ` Ingo Molnar
2008-06-13 10:15           ` Ben Hutchings [this message]
2008-06-13 11:02             ` Ingo Molnar
2008-06-13 15:36               ` Ben Hutchings
2008-07-16 21:37 ` [PATCH] cputopology: Always define CPU topology information [4th try] Nathan Lynch
2008-07-16 22:49   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080613101539.GV11300@solarflare.com \
    --to=bhutchings@solarflare.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®