From: Rik van Riel <riel@redhat.com>
To: Benjamin Kidwell <benjkidwell@yahoo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, benjkidwell@yahoo.com,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: [PATCH] fix UNEVICTABLE_LRU + !PROC_PAGE_MONITOR build
Date: Fri, 13 Jun 2008 14:02:09 -0400 [thread overview]
Message-ID: <20080613140209.044ecfef@cuia.bos.redhat.com> (raw)
In-Reply-To: <636055.3698.qm@web53712.mail.re2.yahoo.com>
Both CONFIG_PROC_PAGE_MONITOR and CONFIG_UNEVICTABLE_LRU depend on
mm/pagewalk.c being built. Create a CONFIG_PAGE_WALKER Kconfig
variable that is automatically selected if needed.
Debugged-by: Benjamin Kidwell <benjkidwell@yahoo.com>
Signed-off-by: Rik van Riel <riel@redhat.com>
---
init/Kconfig | 1 +
mm/Kconfig | 5 +++++
mm/Makefile | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
Index: linux-2.6.26-rc5-mm2/init/Kconfig
===================================================================
--- linux-2.6.26-rc5-mm2.orig/init/Kconfig 2008-06-10 10:46:29.000000000 -0400
+++ linux-2.6.26-rc5-mm2/init/Kconfig 2008-06-13 13:57:11.000000000 -0400
@@ -803,6 +803,7 @@ source "arch/Kconfig"
config PROC_PAGE_MONITOR
default y
depends on PROC_FS && MMU
+ select PAGE_WALKER
bool "Enable /proc page monitoring" if EMBEDDED
help
Various /proc files exist to monitor process memory utilization:
Index: linux-2.6.26-rc5-mm2/mm/Kconfig
===================================================================
--- linux-2.6.26-rc5-mm2.orig/mm/Kconfig 2008-06-11 14:39:43.000000000 -0400
+++ linux-2.6.26-rc5-mm2/mm/Kconfig 2008-06-13 13:58:24.000000000 -0400
@@ -206,9 +206,14 @@ config VIRT_TO_BUS
def_bool y
depends on !ARCH_NO_VIRT_TO_BUS
+# automatically selected by UNEVICTABLE_LRU or PROC_PAGE_MONITOR
+config PAGE_WALKER
+ def_bool n
+
config UNEVICTABLE_LRU
bool "Add LRU list to track non-evictable pages"
default y
+ select PAGE_WALKER
help
Keeps unevictable pages off of the active and inactive pageout
lists, so kswapd will not waste CPU time or have its balancing
Index: linux-2.6.26-rc5-mm2/mm/Makefile
===================================================================
--- linux-2.6.26-rc5-mm2.orig/mm/Makefile 2008-06-10 10:46:29.000000000 -0400
+++ linux-2.6.26-rc5-mm2/mm/Makefile 2008-06-13 13:58:42.000000000 -0400
@@ -13,7 +13,7 @@ obj-y := bootmem.o filemap.o mempool.o
prio_tree.o util.o mmzone.o vmstat.o backing-dev.o \
page_isolation.o $(mmu-y)
-obj-$(CONFIG_PROC_PAGE_MONITOR) += pagewalk.o
+obj-$(CONFIG_PAGE_WALKER) += pagewalk.o
obj-$(CONFIG_BOUNCE) += bounce.o
obj-$(CONFIG_SWAP) += page_io.o swap_state.o swapfile.o thrash.o
obj-$(CONFIG_HAS_DMA) += dmapool.o
prev parent reply other threads:[~2008-06-13 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 20:41 2.6.26-rc5-mm3 reproducible BUG and build failures Benjamin Kidwell
2008-06-12 20:51 ` Benjamin Kidwell
2008-06-13 1:06 ` Andrew Morton
2008-06-13 2:51 ` Benjamin Kidwell
2008-06-13 18:02 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080613140209.044ecfef@cuia.bos.redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benjkidwell@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®