From: Pierre Ossman <drzeus@drzeus.cx>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org, Harald Welte <laforge@openmoko.org>,
Thomas Kleffel <tk@maintech.de>,
Roman Moravcik <roman.moravcik@gmail.com>,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [patch 05/15] MMC: Fix S3C24XX IRQ enable during PIO transfers From: Roman Moracik <roman.moravcik@gmail.com>
Date: Sat, 14 Jun 2008 18:20:24 +0200 [thread overview]
Message-ID: <20080614182024.03422126@mjolnir.drzeus.cx> (raw)
In-Reply-To: <20080606155525.495951151@fluff.org.uk>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Fri, 06 Jun 2008 16:51:22 +0100
Ben Dooks <ben-linux@fluff.org> wrote:
> Fix Bug #677 - I/O errors on heavy microSD writes for 2.6.22.x.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> Index: linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c
> ===================================================================
> --- linux-2.6.26-rc5-q.orig/drivers/mmc/host/s3cmci.c 2008-06-06 15:46:01.000000000 +0100
> +++ linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c 2008-06-06 15:46:03.000000000 +0100
> @@ -313,6 +313,7 @@ static void pio_tasklet(unsigned long da
> {
> struct s3cmci_host *host = (struct s3cmci_host *) data;
>
> + disable_irq(host->irq);
>
This seems harsh. Can't you just fiddle with the interrupt mask of this
specific device?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-06-14 16:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 15:51 [patch 00/15] S3C24XX SD/MMC driver series Ben Dooks
2008-06-06 15:51 ` [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel <tk@maintech.de> Ben Dooks
2008-06-07 5:49 ` Andrew Morton
2008-06-07 12:22 ` Ben Dooks
2008-06-07 19:13 ` Andrew Morton
2008-06-07 19:50 ` Ben Dooks
2008-06-14 16:18 ` Pierre Ossman
2008-06-17 23:02 ` Ben Dooks
2008-06-06 15:51 ` [patch 02/15] MMC: S3C24XX MMC/SD driver write fixes From: Harald Welte <laforge@openmoko.org> Ben Dooks
2008-06-06 15:51 ` [patch 03/15] MMC: DMA free fix for S3C24XX SD/MMC driver From: OpenMoko SVN " Ben Dooks
2008-06-06 15:51 ` [patch 04/15] MMC: S3C24XX MMC/SD stop fix From: Thomas Kleffel <tk@maintech.de> Ben Dooks
2008-06-06 15:51 ` [patch 05/15] MMC: Fix S3C24XX IRQ enable during PIO transfers From: Roman Moracik <roman.moravcik@gmail.com> Ben Dooks
2008-06-14 16:20 ` Pierre Ossman [this message]
2008-06-06 15:51 ` [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver Ben Dooks
2008-06-14 16:22 ` Pierre Ossman
2008-06-17 23:20 ` Ben Dooks
2008-06-06 15:51 ` [patch 07/15] MMC: Add support to invert S3C24XX write protect line Ben Dooks
2008-06-06 15:51 ` [patch 08/15] MMC: Ensure host->mrq->data is valid in S3C24XX driver Ben Dooks
2008-06-06 15:51 ` [patch 09/15] MMC: Allow card-detect to be on an non-IRQ capable pin on the S3C24XX Ben Dooks
2008-06-14 16:24 ` Pierre Ossman
2008-06-06 15:51 ` [patch 10/15] MMC: Fix s3c24xx driver s3c2410_dma_request() return code check Ben Dooks
2008-06-06 15:51 ` [patch 11/15] MMC: Fix the retcode in the S3C24XX MMC/SD driver Ben Dooks
2008-06-14 16:25 ` Pierre Ossman
2008-06-17 23:33 ` Ben Dooks
2008-06-06 15:51 ` [patch 12/15] MMC: S3C24XX MMC/SD driver fixes for sg_ access Ben Dooks
2008-06-06 15:51 ` [patch 13/15] MMC: s3cmci: Add MODULE_ALIAS() entries for the platform devices Ben Dooks
2008-06-06 15:51 ` [patch 14/15] MMC: Fix use of msecs where jiffies are needed Ben Dooks
2008-06-06 15:51 ` [patch 15/15] MMC: Add media presence detection to request handling Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080614182024.03422126@mjolnir.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=ben-linux@fluff.org \
--cc=laforge@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roman.moravcik@gmail.com \
--cc=tk@maintech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®