From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Matthew Wilcox <matthew@wil.cx>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] resend, ptrace && SIGKILL fixes
Date: Mon, 16 Jun 2008 18:20:16 +0400 [thread overview]
Message-ID: <20080616142016.GA13339@tv-sign.ru> (raw)
On 06/10, Oleg Nesterov wrote:
>
> These 2 patches don't depend on each other. Each change is user visible,
> and I am not really sure it can't confuse debuggers/etc. The explicit
> ack/nack from maintainers is wanted.
I'm mostly worried about do_exit()->ptrace_notify(), with these patches
we never notify the tracer if the tracee was SIGKILL'ed. The current
behaviour depends on arch_ptrace_stop_needed(), this is not good either.
Anyway, I think these patches are fixes. Suppose we send SIGKILL to the
traced task which does ptrace_notify(). If the signal is delivered before
ptrace_notify() takes ->siglock, the tracee sleeps in TASK_TRACED state
and becomes "unkillable". If ptrace_notify() wins, we kill the tracee.
This can't be good.
The 3rd patch is new.
Oleg.
reply other threads:[~2008-06-16 14:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616142016.GA13339@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®