mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: lethal@linux-sh.org
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] move arch/sh/lib/io.o to obj-y
Date: Wed, 18 Jun 2008 01:30:53 +0300	[thread overview]
Message-ID: <20080617223053.GJ25911@cs181133002.pp.htv.fi> (raw)

EXPORT_SYMBOL's in lib-y considered harmful:

<--  snip  -->

...
  MODPOST 1837 modules
ERROR: "__raw_readsl" [drivers/ssb/ssb.ko] undefined!
ERROR: "__raw_writesl" [drivers/ssb/ssb.ko] undefined!
ERROR: "__raw_writesl" [drivers/net/smc91x.ko] undefined!
ERROR: "__raw_readsl" [drivers/net/smc91x.ko] undefined!
ERROR: "__raw_writesl" [drivers/net/3c59x.ko] undefined!
ERROR: "__raw_readsl" [drivers/net/3c59x.ko] undefined!
...
make[2]: *** [__modpost] Error 1

<--  snip  -->

Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

b4dec4046b4e491c0ad2cb1046699f22d635fcab diff --git a/arch/sh/lib/Makefile b/arch/sh/lib/Makefile
index 3424b90..265aca0 100644
--- a/arch/sh/lib/Makefile
+++ b/arch/sh/lib/Makefile
@@ -2,9 +2,11 @@
 # Makefile for SuperH-specific library files..
 #
 
-lib-y  = delay.o io.o memset.o memmove.o memchr.o \
+lib-y  = delay.o memset.o memmove.o memchr.o \
 	 checksum.o strlen.o div64.o div64-generic.o
 
+obj-y				+= io.o
+
 memcpy-y			:= memcpy.o
 memcpy-$(CONFIG_CPU_SH4)	:= memcpy-sh4.o
 

         reply	other threads:[~2008-06-17 22:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  0:36 [2.6 patch] sh/kernel/ cleanups Adrian Bunk
2008-06-17 22:33 ` [2.6 patch] sh: make pcibios_max_latency static Adrian Bunk
2008-06-17 22:31   ` [2.6 patch] sh: make EARLY_PCI_OP's static Adrian Bunk
2008-06-17 22:30     ` [2.6 patch] sh/boards/dreamcast/rtc.c: make 2 functions static Adrian Bunk
2008-06-17 22:30       ` Adrian Bunk [this message]
2008-06-17 22:30         ` [2.6 patch] sh dreamcast: export board_pci_channels Adrian Bunk
2008-06-17 22:30           ` [2.6 patch] sh: export get_cpu_subtype Adrian Bunk
2008-06-18  7:21             ` Change console to another UART oihana
2008-06-18  9:43               ` Nobuhiro Iwamatsu
2008-06-24  4:03             ` [2.6 patch] sh: export get_cpu_subtype Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080617223053.GJ25911@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®