From: Christoph Hellwig <hch@infradead.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
akpm@linux-foundation.org, zach.brown@oracle.com,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] aio: invalidate async directio writes
Date: Wed, 18 Jun 2008 15:48:23 -0400 [thread overview]
Message-ID: <20080618194823.GA7237@infradead.org> (raw)
In-Reply-To: <x49abhiy1bb.fsf@segfault.boston.devel.redhat.com>
On Wed, Jun 18, 2008 at 03:45:28PM -0400, Jeff Moyer wrote:
> > Can we please move all these aio_complete calls to user context? Having
> > AIO contexts completing from irq context is a major pain for complex
> > filesystems like XFS.
>
> Can you help me understand why this is a pain? I'm having trouble
> making the connection.
With your patch we complete aio dio write request in user context, which
is great for filesystems that need to do more complex activity in the
completion handler, e.g. XFS for the unwritten extent conversion. But
only doing this for the write case is only very partially useful, we
should be doing this for the read case, too.
See fs/xfs/linux-2.6/xfs_aops.c:xfs_end_io_direct() for what I mean.
next prev parent reply other threads:[~2008-06-18 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 18:09 Jeff Moyer
2008-06-18 18:22 ` Christoph Hellwig
2008-06-18 19:45 ` Jeff Moyer
2008-06-18 19:48 ` Christoph Hellwig [this message]
2008-06-19 7:51 ` Peter Zijlstra
2008-06-19 13:50 ` Jeff Moyer
2008-06-19 13:58 ` Peter Zijlstra
2008-06-19 14:05 ` Jeff Moyer
2008-06-19 17:50 ` Zach Brown
2008-06-19 17:23 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618194823.GA7237@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®