From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] i386: fix vmalloc_sync_all() for Xen
Date: Thu, 19 Jun 2008 14:27:18 +0200 [thread overview]
Message-ID: <20080619122718.GI7640@elte.hu> (raw)
In-Reply-To: <485A465D.76E4.0078.0@novell.com>
* Jan Beulich <jbeulich@novell.com> wrote:
> >Given that the usermode PGDs will never need syncing, I think it would
> >be better to use KERNEL_PGD_PTRS, and define
> >
> >#define sync_index(a) (((a) >> PMD_SHIFT) - KERNEL_PGD_BOUNDARY)
> >
> >for a massive 192 byte saving in bss.
>
> I was considering that, too, but didn't do so for simplicity's sake.
> If I'll have to re-spin the patch, I may as well do it.
you could do it as a second add-on patch as well - or as a respun patch.
Jeremy, is it now Acked-by you?
Ingo
next prev parent reply other threads:[~2008-06-19 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 11:40 Jan Beulich
2008-06-18 20:01 ` Jeremy Fitzhardinge
2008-06-19 9:43 ` Jan Beulich
2008-06-19 12:27 ` Ingo Molnar [this message]
2008-06-19 15:28 ` Jeremy Fitzhardinge
2008-06-19 14:45 ` Jeremy Fitzhardinge
2008-06-19 16:01 ` Jan Beulich
2008-06-19 18:16 ` Jeremy Fitzhardinge
2008-06-20 6:58 ` Jan Beulich
2008-06-20 16:10 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080619122718.GI7640@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome