From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759485AbYFTPTj (ORCPT ); Fri, 20 Jun 2008 11:19:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756611AbYFTPT3 (ORCPT ); Fri, 20 Jun 2008 11:19:29 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:32211 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756232AbYFTPT3 (ORCPT ); Fri, 20 Jun 2008 11:19:29 -0400 Date: Fri, 20 Jun 2008 08:13:52 -0700 From: Randy Dunlap To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Jeff Garzik , netdev@vger.kernel.org Subject: Re: [patch] fix 3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource' Message-Id: <20080620081352.6cb4f9df.randy.dunlap@oracle.com> In-Reply-To: <20080620093316.GA19003@elte.hu> References: <20080620093316.GA19003@elte.hu> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jun 2008 11:33:16 +0200 Ingo Molnar wrote: > commit 2538003ce2ea0b936d273692bc4e51c5b52fe70d > Author: Ingo Molnar > Date: Fri Jun 20 11:29:31 2008 +0200 > > fix 3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource' > > -tip testing found the following build failure: > > drivers/built-in.o: In function `corkscrew_setup': > 3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource' > > which happens if 3c515.c is build without CONFIG_PNP: > > http://redhat.com/~mingo/misc/config-Fri_Jun_20_10_02_43_CEST_2008.bad > > the reason is pnp_irq() use outside of its __ISAPNP__ section. > > corkscrew_setup() always called with NULL in the !__ISAPNP__ case, but > also check this condition to make sure. > > Signed-off-by: Ingo Molnar Patch is in Jeff's tree. Sometimes we need to have build patches merged sooner rather than later... :( > diff --git a/drivers/net/3c515.c b/drivers/net/3c515.c > index 105a8c7..09dd063 100644 > --- a/drivers/net/3c515.c > +++ b/drivers/net/3c515.c > @@ -573,7 +573,12 @@ static int corkscrew_setup(struct net_device *dev, int ioaddr, > DECLARE_MAC_BUF(mac); > > if (idev) { > +#ifdef __ISAPNP__ > irq = pnp_irq(idev, 0); > +#else > + /* Can not happen - in the !PNP case we always pass in NULL */ > + BUG_ON(1); > +#endif > vp->dev = &idev->dev; > } else { > irq = inw(ioaddr + 0x2002) & 15; > -- --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/