From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbYFTK2H (ORCPT ); Fri, 20 Jun 2008 06:28:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752144AbYFTK14 (ORCPT ); Fri, 20 Jun 2008 06:27:56 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:52370 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbYFTK1z (ORCPT ); Fri, 20 Jun 2008 06:27:55 -0400 Date: Fri, 20 Jun 2008 12:27:33 +0200 From: Ingo Molnar To: Jack Steiner Cc: tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, the arch/x86 maintainers Subject: Re: [PATCH] - Fix stack overflow for large values of MAX_APICS Message-ID: <20080620102733.GB32500@elte.hu> References: <20080620025104.GA25571@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080620025104.GA25571@sgi.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0002] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jack Steiner wrote: > physid_mask_of_physid() causes a huge stack (12k) to be created if the > number of APICS is large. Replace physid_mask_of_physid() with a new > function that does not create large stacks. This is a problem only on > large x86_64 systems. ah, that indeed makes sense. Applied to tip/x86/uv - thanks Jack. > Ingo - the "Increase MAX_APICS patch" can now works. Do you want me to > resend??? no need, i have reactivated it in tip/x86/uv. (after your physid_mask_of_physid() patch, so that it's still all bisectable) Ingo