From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: drzeus-mmc@drzeus.cx, Ben Dooks <ben-linux@fluff.org>
Subject: Re: MMC: card test driver should not be builtin with other card support
Date: Fri, 20 Jun 2008 12:01:15 +0100 [thread overview]
Message-ID: <20080620110115.GB21835@fluff.org.uk> (raw)
In-Reply-To: <20080620105802.173598466@fluff.org.uk>
On Fri, Jun 20, 2008 at 11:58:02AM +0100, ben@fluff.org.uk wrote:
> The mmc test driver and mmc block driver will attempt to bind
> to any card present in the system, which means only one of these
> drivers will end up with the card. If either one of these is selected
> as builtin, ensure the other does not get built.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> Index: linux-2.6.26-rc6-sdmmc3/drivers/mmc/card/Kconfig
> ===================================================================
> --- linux-2.6.26-rc6-sdmmc3.orig/drivers/mmc/card/Kconfig 2008-06-20 11:53:08.000000000 +0100
> +++ linux-2.6.26-rc6-sdmmc3/drivers/mmc/card/Kconfig 2008-06-20 11:53:29.000000000 +0100
> @@ -6,7 +6,7 @@ comment "MMC/SD Card Drivers"
>
> config MMC_BLOCK
> tristate "MMC block device driver"
> - depends on BLOCK
> + depends on BLOCK && MMC_TEST != y
> default y
> help
> Say Y here to enable the MMC block device driver support.
> @@ -42,6 +42,7 @@ config SDIO_UART
> config MMC_TEST
> tristate "MMC host test driver"
> default n
> + depends on MMC_BLOCK != y
> help
> Development driver that performs a series of reads and writes
> to a memory card in order to expose certain well known bugs
This is what I would have liked to have done in Kconfig, but of course
the system fails with a circular dependency error. Is there any way
to get this done without some horrible hacks?
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-06-20 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 10:58 ben
2008-06-20 11:01 ` Ben Dooks [this message]
2008-06-20 17:08 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620110115.GB21835@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®